Skip to content

Commit 0f66fb7

Browse files
committed
go/internal/gccgoimporter: fix up gccgo installation test
Change the TestInstallationImporter testpoint to query type information for sort.Search instead of sort.Ints. The latter function changed recently (1.16 timeframe), parameter "a" is now "x". A better candidate for this sort of query is sort.Search, which has been stable for a while. Fixes golang#44425. Change-Id: I314476eac0b0802f86f5cbce32195cab2926db83 Reviewed-on: https://go-review.googlesource.com/c/go/+/294290 Trust: Than McIntosh <thanm@google.com> Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
1 parent e78e04c commit 0f66fb7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/go/internal/gccgoimporter/gccgoinstallation_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ func TestInstallationImporter(t *testing.T) {
184184
{pkgpath: "io", name: "ReadWriter", want: "type ReadWriter interface{Reader; Writer}"},
185185
{pkgpath: "math", name: "Pi", want: "const Pi untyped float"},
186186
{pkgpath: "math", name: "Sin", want: "func Sin(x float64) float64"},
187-
{pkgpath: "sort", name: "Ints", want: "func Ints(a []int)"},
187+
{pkgpath: "sort", name: "Search", want: "func Search(n int, f func(int) bool) int"},
188188
{pkgpath: "unsafe", name: "Pointer", want: "type Pointer"},
189189
} {
190190
runImporterTest(t, imp, nil, &test)

0 commit comments

Comments
 (0)