Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotate profiles when slowdowns with known causes are detected #5383

Open
mgaudet opened this issue Feb 25, 2025 · 2 comments
Open

Annotate profiles when slowdowns with known causes are detected #5383

mgaudet opened this issue Feb 25, 2025 · 2 comments

Comments

@mgaudet
Copy link

mgaudet commented Feb 25, 2025

Recently we had someone asking about a profile that seemed to be spending a lot of time capturing the stack. It turns out, that this only happens if a non-standard pref is set -or- Devtools is open.

I wonder if we could annotate either whole profiles, or even just frames, indicating "Hey, if you see this and are worried about this, have you tried... " (in this case, closing devtools and trying again).

┆Issue is synchronized with this Jira Task

@mstange
Copy link
Contributor

mstange commented Feb 25, 2025

We have an existing warning for "you were profiling a debug build" which is based on the value of profile.meta.debug. We could generalize this to be profile.meta.warningsAboutCircumstancesThatMayHaveCompromisedUsefulnessOfProfilingData and then put an appropriate value in that field at the platform level.

@julienw
Copy link
Contributor

julienw commented Mar 3, 2025

We could do some things such as:

  • package all modified prefs inside the profile data (and display them somewhere in our UI)
  • detect if devtools is open somewhere (and maybe label the related track appropriately)
  • report the value for MOZ_OPTIMIZE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants