Skip to content

Commit 3dcd62d

Browse files
committed
Makefile: do not compile rust/download_web with old toolchain, again
rust/download_web now fails on Fedora 39 (rustc 1.37) with: error[E0658]: use of unstable library feature 'ptr_cast' --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/object-0.19.0/src/pod.rs:35:30 | 35 | let val = unsafe { &*ptr.cast() }; | ^^^^ | = note: for more information, see rust-lang/rust#60602 error[E0658]: use of unstable library feature 'ptr_cast' --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/object-0.19.0/src/pod.rs:53:52 | 53 | let slice = unsafe { slice::from_raw_parts(ptr.cast(), count) }; | ^^^^ | = note: for more information, see rust-lang/rust#60602 error[E0658]: use of unstable library feature 'ptr_cast' --> /root/.cargo/registry/src/github.com-1ecc6299db9ec823/object-0.19.0/src/pod.rs:65:66 | 65 | unsafe { slice::from_raw_parts(slice::from_ref(val).as_ptr().cast(), size) } | ^^^^ | = note: for more information, see rust-lang/rust#60602 This feature is https://doc.bccnsoft.com/docs/rust-1.36.0-docs-html/unstable-book/library-features/ptr-cast.html, stabilized in rust-lang/rust#62713 merged in Rust 1.38 (2019-09-26).
1 parent 41cdecc commit 3dcd62d

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

Makefile

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,9 +87,11 @@ endif
8787
ifneq ($(call can-run,$(CARGO) --version),y)
8888
SUBDIRS_BLACKLIST += rust%
8989
else
90-
# Old versions of rustc fail to build socket2-0.3.12 because:
90+
# Old versions of rustc (<=1.34) fail to build socket2-0.3.12 because:
9191
# error[E0658]: use of unstable library feature 'maybe_uninit' (see issue #53491)
92-
ifeq ($(call can-run,$(RUSTC) --version | grep '^rustc 1\.\(3[0-4]\)\.'),y)
92+
# Old versions of rustc (<1.38) fail to build object-0.19.0 because:
93+
# use of unstable library feature 'ptr_cast'
94+
ifeq ($(call can-run,$(RUSTC) --version | grep '^rustc 1\.\(3[0-7]\)\.'),y)
9395
SUBDIRS_BLACKLIST += rust/download_web%
9496
endif
9597
endif

machines/Dockerfile-fedora29

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ COPY . /shared/
6060
CMD ["/run_shared_test.sh"]
6161

6262
# make list-nobuild:
63-
# Global blacklist: latex%
63+
# Global blacklist: latex% rust/download_web%
6464
# In sub-directories:
6565
# c:
6666
# glossaries:
@@ -74,7 +74,7 @@ CMD ["/run_shared_test.sh"]
7474
# rust:
7575
# verification:
7676
# With gcc -m32:
77-
# Global blacklist: latex%
77+
# Global blacklist: latex% rust/download_web%
7878
# In sub-directories:
7979
# c: gtk_alpha_window
8080
# glossaries:

0 commit comments

Comments
 (0)