Skip to content
This repository was archived by the owner on Dec 5, 2024. It is now read-only.

TypeScript types broken with latest version of popper-core #351

Closed
bengry opened this issue Apr 14, 2020 · 0 comments · Fixed by #352
Closed

TypeScript types broken with latest version of popper-core #351

bengry opened this issue Apr 14, 2020 · 0 comments · Fixed by #352

Comments

@bengry
Copy link

bengry commented Apr 14, 2020

What went wrong?

With the latest version of @popperjs/core the type of Modifier was changed from type Modifier<Options> to type Modifier<Name, Options> as part of floating-ui/floating-ui#1073 (relevant changeset).

This causes the types of react-popper to break too, and apps that rely on it and use TypeScript, unless they have "skipLibCheck": true in their tsconfig.json (which is a bad practice IMO).

Packages versions

  • Popper.js: 2.3.2
  • react-popper: 2.2.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: TypeScript types broken with latest popperjs-core
1 participant
@bengry