Tab Sync re-opens closed tabs and creates duplicates

[powerpaul17]

Which version of floccus are you using?

5.4.3

How many bookmarks do you have, roughly?

2k

Are you using other means to sync bookmarks in parallel to floccus?

No

Sync method

Nextcloud Bookmarks

Which browser are you using? In case you are using the phone App, specify the Android or iOS version and device please.

Firefox 134.0.2

Which version of Nextcloud Bookmarks are you using? (if relevant)

No response

Which version of Nextcloud? (if relevant)

No response

What kind of WebDAV server are you using? (if relevant)

No response

Describe the Bug

I have setup synchronization of open tabs. On every sync run, some previously closed tabs are opened again. Sometimes also duplicates are created.

Expected Behavior

Closed tabs should remain closed and no duplicates should be opened.

To Reproduce

Set up synchronization of open tabs. Close some tabs and synchronize. Wait for them to reappear.

Debug log provided

• I have provided a debug log file

[github-actions]

Hello 👋

Thank you for taking the time to open this issue with floccus. I know it's frustrating when software
causes problems. You have made the right choice to come here and open an issue to make sure your problem gets looked at
and if possible solved.
I'm Marcel and I created floccus a few years ago, maintaining it ever since. I currently work for Nextcloud
which leaves me with less time for side projects like this one than I used to have.
I still try to answer all issues and if possible fix all bugs here, but it sometimes takes a while until I get to it.
Until then, please be patient.
Note also that GitHub is a place where people meet to make software better together. Nobody here is under any obligation
to help you, solve your problems or deliver on any expectations or demands you may have, but if enough people come together we can
collaborate to make this software better. For everyone.
Thus, if you can, you could also have a look at other issues to see whether you can help other people with your knowledge
and experience. If you have coding experience it would also be awesome if you could step up to dive into the code and
try to fix the odd bug yourself. Everyone will be thankful for extra helping hands!
To continue the development and maintenance of this project in a sustainable way I ask that you donate to the project when opening an issue
(or at least once your issue is solved), if you're not a donor already.
You can find donation options at https://floccus.org/donate/. Thank you!

One last word: If you feel, at any point, like you need to vent, this is not the place for it; you can go to the Nextcloud forum,
to twitter or somewhere else. But this is a technical issue tracker, so please make sure to
focus on the tech and keep your opinions to yourself.

I look forward to working with you on this issue
Cheers 💙

[marcelklehr]

Mmh, I cannot reproduce this offhand.

[powerpaul17]

Should I send you a debug log or something? I'm willing to contribute what is possible/necessary to fix this since it would be a perfect solution for me.

[marcelklehr]

Perhaps you can try to zero in on the exact steps to reproduce this, try to notice in which cases it happens and when it doesn't. You could turn off Auto-Sync and sync manually from time to time to make it easier to pinpoint which changes cause this. Another thing: Which version of Nextcloud Bookmarks are you using?

[marcelklehr]

Mh, I've witnessed it just now on my on prod instance, it's weird. For me it seemed to stem from my use of firefox containers. Are you using these as well or any other kind of addon that could mess with tabs?

[powerpaul17]

I use the built-in tab containers for work, but only a few which I close after work. Also TabStash but it shouldn't mess with the open tabs. I only use it for bookmarking to a separate folder.

From what I observed, there are always the same tabs reappearing, changing from time to time, although not necessarily the newest ones or recently used ones. Also they got moved to the end of the list.

Maybe a timestamp issue or so?

[marcelklehr]

there are always the same tabs reappearing

Could it be that those tabs are for sites that you need to login to? It might be that Nextcloud Bookmarks follows the redirect to the login page when the bookmarks for such tabs are created, because it's not logged in 🤔

[powerpaul17]

Could it be that those tabs are for sites that you need to login to?

No, some have logins, but not all. Does Nextcloud Bookmarks not save the URL it gets sent? What I noticed is that Brave Search for example appends a query parameter which changes but the URL is essentially the same. These tabs get duplicated more often than others.

[powerpaul17]

Nextcloud Bookmarks version is 15.0.5, btw.

[marcelklehr]

I was able to reproduce this now:

1. Trigger sync
2. Close a tab while sync is running
3. After sync is done, trigger sync again
4. Tab comes back

[marcelklehr]

My current solution is to shorten the wait time that was previously in place for tab sync in order to avoid the closing of tabs happening during a sync run, but this is not a bullet proof fix, of course.

[powerpaul17]

Wow, nice catch 😲 I tried it and it seems to work. I'll see, if it also works with my other machine(s)..

[marcelklehr]

I tried it and it seems to work.

You're running floccus from git? 🤯

[powerpaul17]

No, I tried to wait for the synchronization to finish before closing any tabs and they didn't reappear..

[jultty]

I've been experiencing this on LibreWolf 135.0.1-1 and Floccus v5.4.4 connected to WebDAV on NextCloud 30.0.5.

Sometimes it's one or two tabs, sometimes several more. I noticed that one single pinned tab I had would also be duplicated at the end of the tab bar sometimes, and that stopped when I unpinned it, but the issue with closed tabs reappearing persisted.

Can easily reproduce on my end by:

1. Disabling all add-ons except for Floccus
2. Quitting the browser and restarting
3. Manually triggering a tab sync
4. Old tabs come back
5. Close the tabs, manually trigger a tab sync
6. Old tabs come back again
7. Close the tabs, manually triger a tab sync
8. A single tab comes back, the one that was in the start of the tab bar
9. Close that tab, manually triger a tab sync
10. No tabs reappear at this point

[jultty]

I've been observing this consistently happen on sync and I don't believe it has anything specifically to do with tabs.

I was just now reorganizing some bookmarks in separate, nested directories and started noticing my changes get reversed. Upon checking floccus, a sync had just happened and it seems to not be able to tell which state is newer.

I'm attaching logs for two sessions in which this happened to tabs, which is easier to notice and reproduce. I was not able to reproduce the bookmark issue, but will come back with a log for that too if I notice it again.

floccus_tabs-5.4.4-2025-03-09-redacted.log
floccus_tabs-5.4.4-2025-03-10-redacted.log