Skip to content

Commit 230774c

Browse files
author
Paulo Gomes
committed
build: disable go test -race for arm64
Race detection is not working properly in our arm64 runners. It has been tested against both M1 and linux arm64 machines and in both cases the results were aligned with the other platforms. By disabling this we can ensure race detection is being enforced on the other platforms, and we can later review this position. Signed-off-by: Paulo Gomes <paulo.gomes@weave.works>
1 parent f1799dc commit 230774c

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

.github/workflows/e2e.yaml

+8
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,14 @@ jobs:
7373
env:
7474
TEST_AZURE_ACCOUNT_NAME: ${{ secrets.TEST_AZURE_ACCOUNT_NAME }}
7575
TEST_AZURE_ACCOUNT_KEY: ${{ secrets.TEST_AZURE_ACCOUNT_KEY }}
76+
77+
# Temporarily disabling -race for arm64 as our GitHub action
78+
# runners don't seem to like it. The race detection was tested
79+
# on both Apple M1 and Linux arm64 with successful results.
80+
#
81+
# We should reenable go test -race for arm64 runners once the
82+
# current issue is resolved.
83+
GO_TEST_ARGS: ''
7684
run: make test
7785
- name: Prepare
7886
id: prep

0 commit comments

Comments
 (0)