Skip to content

Commit b6a033c

Browse files
author
Max Jonas Werner
committed
include Secret name in returned errors
Signed-off-by: Max Jonas Werner <mail@makk.es>
1 parent 9dd8b2f commit b6a033c

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

internal/helm/registry/auth.go

+4-3
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,16 @@ func LoginOptionFromSecret(registryURL string, secret corev1.Secret) (registry.L
1919
if secret.Type == corev1.SecretTypeDockerConfigJson {
2020
dockerCfg, err := config.LoadFromReader(bytes.NewReader(secret.Data[corev1.DockerConfigJsonKey]))
2121
if err != nil {
22-
return nil, fmt.Errorf("unable to load Docker config: %w", err)
22+
return nil, fmt.Errorf("unable to load Docker config from Secret '%s': %w", secret.Name, err)
2323
}
2424
parsedURL, err := url.Parse(registryURL)
2525
if err != nil {
26-
return nil, fmt.Errorf("unable to parse registry URL: %w", err)
26+
return nil, fmt.Errorf("unable to parse registry URL '%s' while reconciling Secret '%s': %w",
27+
registryURL, secret.Name, err)
2728
}
2829
authConfig, err := dockerCfg.GetAuthConfig(parsedURL.Host)
2930
if err != nil {
30-
return nil, fmt.Errorf("unable to get authentication data from Secret: %w", err)
31+
return nil, fmt.Errorf("unable to get authentication data from Secret '%s': %w", secret.Name, err)
3132
}
3233
username = authConfig.Username
3334
password = authConfig.Password

0 commit comments

Comments
 (0)