Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Solidity compilers are not downloaded to ~/.svm on macOS #6925

Closed
2 tasks done
macaujack opened this issue Jan 28, 2024 · 4 comments · Fixed by #8403
Closed
2 tasks done

docs: Solidity compilers are not downloaded to ~/.svm on macOS #6925

macaujack opened this issue Jan 28, 2024 · 4 comments · Fixed by #8403
Assignees
Labels
A-compiler Area: compiler A-docs Area: docs A-installer Area: installer T-bug Type: bug

Comments

@macaujack
Copy link

Component

Forge

Have you ensured that all of these are up to date?

  • Foundry
  • Foundryup

What version of Foundry are you on?

forge 0.2.0 (6fc7463 2024-01-05T00:17:41.668342000Z)

What command(s) is the bug in?

No response

Operating System

macOS (Apple Silicon)

Describe the bug

The README says:

Automatic Solidity compiler version detection & installation (under ~/.svm)

However, on my machine (macOS Apple silicon, system version 14.1), the compilers are downloaded to /Users/yourUsername/Library/Application Support/svm. Seems like a mistake in README.

@macaujack macaujack added the T-bug Type: bug label Jan 28, 2024
@gakonst gakonst added this to Foundry Jan 28, 2024
@github-project-automation github-project-automation bot moved this to Todo in Foundry Jan 28, 2024
@DaniPopes
Copy link
Member

The directory is resolved here: https://github.com/alloy-rs/svm-rs/blob/8423030a242915ec8629e6f1be1cd2f5a876ec70/crates/svm-rs/src/lib.rs#L51

which was updated in alloy-rs/svm-rs#87

I think we just have to update the docs

cc @mattsse

@piavgh
Copy link

piavgh commented Mar 19, 2024

@DaniPopes : so if I don't have .svm folder in my $HOME, where does it install? (I tried which solc and it returns ~/.cargo/bin/solc, but I don't think Forge uses that location)

@piavgh
Copy link

piavgh commented Mar 19, 2024

I can reproduce the issue now, the reason is if I don't specify solc = "0.8.25" in foundry.toml file, it will try to install solc v0.8.25 again (even if it's already installed by svm-rs and is set as the global)

If I specify solc = "0.8.25" in foundry.toml, it works properly

@CadeMichael
Copy link

CadeMichael commented Mar 21, 2024

if everything is installed to '/Users/username/Library/Application Support/svm' if you want to uninstall a certain compiler version do you just have to remove it from that dir? (On macOS)

@zerosnacks zerosnacks added A-installer Area: installer A-compiler Area: compiler A-docs Area: docs labels Jul 10, 2024
@zerosnacks zerosnacks self-assigned this Jul 10, 2024
@zerosnacks zerosnacks changed the title Solidity compilers are not downloaded to ~/.svm on macOS docs: Solidity compilers are not downloaded to ~/.svm on macOS Jul 10, 2024
@jenpaff jenpaff moved this from Todo to Completed in Foundry Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiler Area: compiler A-docs Area: docs A-installer Area: installer T-bug Type: bug
Projects
Status: Completed
5 participants