You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: CONTRIBUTING.md
+12-12Lines changed: 12 additions & 12 deletions
Original file line number
Diff line number
Diff line change
@@ -3,7 +3,7 @@
3
3
## Testing changes locally
4
4
5
5
You might try a TDD approach and add tests within the `test` directory,
6
-
to try different configs, you may find it easier to try out changes in
6
+
to try different configs you may find it easier to try out changes in
7
7
a separate local directory.
8
8
9
9
You can run [`npm link`](https://docs.npmjs.com/cli/link) for this purpose,
@@ -18,7 +18,7 @@ npm link ../eslint-plugin-jsdoc
18
18
19
19
After running `npm install` to get the latest dependencies and devDependencies,
20
20
you can run the following command to update the `dist` files, with `dist/index.js`
21
-
being the `main`entrance point from `package.json`:
21
+
being the `main`entry point from `package.json`:
22
22
23
23
```shell
24
24
npm run build
@@ -33,22 +33,22 @@ items needing fixing.
33
33
34
34
## Documentation building
35
35
36
-
In order to make changes that are reflected in the README, you will need to
36
+
To make changes that are reflected in the README, you will need to
37
37
modify files within the `.README` directory. `.README/README.md` contains the
38
38
main README skeleton and details on the project, its global `settings`, etc.,
39
-
while the documentation for specific rules (that will get pulled into the
39
+
while the documentation for specific rules (that will be pulled into the
40
40
README) ought to be modified within the relevant file within `.README/rules`.
41
41
Once these files are modified, you can run `npm run create-readme` to have
42
42
these files integrated into the main `/README.md`. While you should include
43
-
the built file in your PR, you will do not want to make manual changes
44
-
directly to this file as they will be overwritten.
43
+
the built file in your PR, you will not want to make manual changes
44
+
directly to this file, as they will be overwritten.
45
45
46
46
## Testing
47
47
48
48
Tests are expected. Each rule file should be in CamelCase (despite the rule names themselves being hyphenated) and should be added within `test/assertions` and then imported/required by
49
49
`test/rules/index.js`.
50
50
51
-
Each rule file should be an ESM default export of an object which has `valid` and `invalid` array properties containing the tests. Tests of each type should be provided.
51
+
Each rule file should be an ESM default export of an object that has `valid` and `invalid` array properties containing the tests. Tests of each type should be provided.
52
52
53
53
`parserOptions` will be `ecmaVersion: 6` by default, but tests can override `parserOptions`
54
54
with their own.
@@ -57,8 +57,8 @@ See ESLint's [RuleTester](https://eslint.org/docs/developer-guide/nodejs-api#rul
57
57
for more on the allowable properties (e.g., `code`, `errors` (for invalid rules),
58
58
`options`, `settings`, etc.).
59
59
60
-
Note that besides `npm test`, there is `npm run test-cov` which shows more
61
-
detailed information on coverage. Coverage should be maintained at 100%, and
60
+
Note that besides `npm test` there is `npm run test-cov`, which shows more
61
+
detailed coverage information. Coverage should be maintained at 100%, and
62
62
if there are a few guards in place for future use, the code block in question
63
63
can be ignored by being preceded by `/* istanbul ignore next */` (including
64
64
for warnings where the block is never passed over (i.e., the block is always
@@ -75,7 +75,7 @@ You can further limit this by providing `--invalid` and/or `--valid` flags
75
75
with a comma-separated list of 0-based indexes that you wish to include (also
76
76
accepts negative offsets from the end, e.g., `-1` for the last item). For
77
77
example, to check the first and third invalid tests of `check-examples`
78
-
alon with the second valid test, you can run:
78
+
along with the second valid test, you can run:
79
79
80
80
`npm run --rule=check-examples --invalid=0,2 --valid=1 test-index`.
81
81
@@ -84,7 +84,7 @@ alon with the second valid test, you can run:
84
84
PRs should be mergeable, [rebasing](https://git-scm.com/book/en/v2/Git-Branching-Rebasing)
85
85
first against the latest `master`.
86
86
87
-
The number of commits will ideally be limited in number, unless extra commits
87
+
The number of commits will ideally be limited unless extra commits
88
88
can better show a progression of features.
89
89
90
90
Commit messages should be worded clearly and the reason for any PR made clear
@@ -96,5 +96,5 @@ We use [semantic-release](https://github.com/semantic-release/semantic-release)
96
96
for preparing releases, so the commit messages (or at least the merge that
97
97
brings them into `master`) must follow the
98
98
[AngularJS commit guidelines](https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines) with a special format such as `feat: describe new feature`
99
-
in order for the releasing to occur and for the described items to be added
99
+
for releases to occur and for the described items to be added
0 commit comments