Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUBMODULE UPDATES] MAPL fix for restarting with stretched grid checkpoints #409

Closed
lizziel opened this issue Apr 19, 2024 · 1 comment · Fixed by geoschem/MAPL#34
Closed
Assignees
Labels
category: Bug Something isn't working topic: Stretched Grid Specific to stretched grid simulation
Milestone

Comments

@lizziel
Copy link
Contributor

lizziel commented Apr 19, 2024

Name and Institution (Required)

Name: Lizzie Lundgren
Institution: Harvard University

Brief Description

This PR fixes a mismatch between stretched grid target coordinates as computed from attributes in the restart file and in the configuration files. Target lat/lon are read from file as REAL4 and written to checkpoint as REAL4. Conversion to radians, however, uses 180 degrees at double precision, while conversion back to lat/lon uses 180 degrees as single precision. This results in failing the online check that the target coordinates in the restart and the configuration file are identical.

Submodule Pull Requests

Related Issues

@lizziel lizziel added category: Bug Something isn't working topic: Stretched Grid Specific to stretched grid simulation labels Apr 19, 2024
@lizziel lizziel added this to the 14.4.0 milestone Apr 19, 2024
@yantosca
Copy link
Contributor

We can now close this issue as geoschem/MAPL#34 has been merged into 14.4.0-alpha.14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Bug Something isn't working topic: Stretched Grid Specific to stretched grid simulation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants