Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default branch to develop #1013

Closed
onedr0p opened this issue Feb 25, 2022 · 4 comments
Closed

Change default branch to develop #1013

onedr0p opened this issue Feb 25, 2022 · 4 comments
Assignees

Comments

@onedr0p
Copy link
Contributor

onedr0p commented Feb 25, 2022

@ajvb would it make sense to set the default branch in the Github project settings to the develop branch? This would lead to less confusion on new PRs which want to be merged into the master branch by default. This would also lead to less confusion on the state of commits, as the develop branch is much more active.

@ajvb
Copy link
Contributor

ajvb commented Feb 25, 2022

The problem with that (at least the last time we looked into it, which was awhile ago) was that go get ...sops... would then pull and install off of the develop branch. Same when used as a library.

If we can resolve that, then absolutely!

@onedr0p
Copy link
Contributor Author

onedr0p commented Feb 25, 2022

I am not sure if that is really an issue, people should absolutely be pulling at specific tags e.g.

go get github.com/mozilla/sops@v3.7.1

or even

go get github.com/mozilla/sops@master

never...

go get github.com/mozilla/sops

@ajvb
Copy link
Contributor

ajvb commented Mar 3, 2022

@onedr0p Agreed. As well, I hadn't been following the deprecation of go get to install binaries. I'd say once we upgrade to Go v1.17 (which will be in the next release), we should give this a try.

@onedr0p
Copy link
Contributor Author

onedr0p commented Jul 5, 2023

Closing in favor of #1238

@onedr0p onedr0p closed this as completed Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants