Skip to content

Update jgit version to v4.0.1.201506240215-r #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mih-kopylov opened this issue Sep 16, 2015 · 7 comments
Closed

Update jgit version to v4.0.1.201506240215-r #216

mih-kopylov opened this issue Sep 16, 2015 · 7 comments
Milestone

Comments

@mih-kopylov
Copy link

Here's the jgit commit that fixes IOException https://github.com/eclipse/jgit/commit/ec6ec3b10fb1ef8dd73a499d0b1f7a7d711b84dd
Here's the jgit release with the fix
https://github.com/eclipse/jgit/releases/tag/v4.0.1.201506240215-r

@ktoso
Copy link
Collaborator

ktoso commented Sep 16, 2015

Great! Would you like to submit a Pull Request updating the version?

@TheSnoozer
Copy link
Collaborator

Is #203 the same Problem?
If so we should think about releasing the 2.2.0

Workaround:
UniversalMediaServer/UniversalMediaServer#627 (comment)

As a workaround, it should work if you make sure that the git bash executable is in your PATH as far as I can understand.

@ktoso
Copy link
Collaborator

ktoso commented Sep 16, 2015

Yeah, let's release once jgit version bumped 👍

@TheSnoozer
Copy link
Collaborator

Updated the version; will run a quick test under windows to make sure everything is stable....
PR eta 20 Mins

EDIT: got stock in a phone call...PR ETA very soon ;-)
EDIT2: Folks be aware of https://issues.apache.org/jira/browse/MNG-5796 when running maven under win 7....

some tests fail with the latest jgit will need to investigate here:

Failed tests:   [0] false (shouldFailWithExceptionWhenNoGitRepoFound)(pl.project
13.maven.git.GitCommitIdMojoIntegrationTest): Expected [MojoExecutionException]
to be thrown but got [AssertionError]
  [1] true (shouldFailWithExceptionWhenNoGitRepoFound)(pl.project13.maven.git.Gi
tCommitIdMojoIntegrationTest): Expected [MojoExecutionException] to be thrown bu
t got [AssertionError]
  [0] false (shouldSkipWithoutFailOnNoGitDirectoryWhenNoGitRepoFound)(pl.project
13.maven.git.GitCommitIdMojoIntegrationTest): expecting empty, but was:<{'git.bu
ild.user.email'='', 'git.build.user.name'=''}>
  [1] true (shouldSkipWithoutFailOnNoGitDirectoryWhenNoGitRepoFound)(pl.project1
3.maven.git.GitCommitIdMojoIntegrationTest): expecting empty, but was:<{'git.bui
ld.user.email'='', 'git.build.user.name'=''}>
  testCraftPropertiesOutputFileWithRelativePath(pl.project13.maven.git.GitCommit
IdMojoTest): expected:<...s\john\Downloads\foo[/target/classes/]git.properties'>
 but was:<...s\john\Downloads\foo[\target\classes\]git.properties'>
  testCraftPropertiesOutputFileWithFullPath(pl.project13.maven.git.GitCommitIdMo
joTest): expected:<...s\john\Downloads\foo[/target/classes/]git.properties'> but
 was:<...s\john\Downloads\foo[\target\classes\]git.properties'>
  testCompareSubrepoInRoot(pl.project13.maven.git.NativeAndJGitProviderTest): Ke
y difference for key: 'git.commit.message.full' expected:<... special characters
 [Σ÷ⁿα±].> but was:<... special characters [├ñ├╢├╝├á├▒].>
  testCompareBasic(pl.project13.maven.git.NativeAndJGitProviderTest): Key differ
ence for key: 'git.commit.message.full' expected:<... special characters [Σ÷ⁿα±]
.> but was:<... special characters [äöüàñ].>
  testCompareISO8601Time(pl.project13.maven.git.NativeAndJGitProviderTest): Key
difference for key: 'git.commit.message.full' expected:<... special characters [
Σ÷ⁿα±].> but was:<... special characters [├ñ├╢├╝├á├▒].>

Tests in error:
  [1] true (shouldGenerateDescribeWithTagOnlyWhenForceLongFormatIsFalse)(pl.proj
ect13.maven.git.GitCommitIdMojoIntegrationTest): Failed creating FileSystemMaven
Sandbox...
  [0] false (shouldSkipGitDescribe)(pl.project13.maven.git.GitCommitIdMojoIntegr
ationTest): Failed creating FileSystemMavenSandbox...
  testCompareSubrepoInChild(pl.project13.maven.git.NativeAndJGitProviderTest): M
ap did not contain [git.build.time] key! Map is: {git.build.user.email=, git.build.user.name=}(..)

Tests run: 115, Failures: 9, Errors: 3, Skipped: 1

Issues also arise with the old jgit version...so I suspect some config issues here...

@TheSnoozer
Copy link
Collaborator

still some failing tests here. not sure if it's my environment. Will deploy another Windows VM....:-(
Stay tuned..

@ktoso ktoso mentioned this issue Sep 25, 2015
@TheSnoozer TheSnoozer changed the title Update jgit version to v4.0.1.201506240215-r to avoid IOException Update jgit version to v4.0.1.201506240215-r Sep 29, 2015
@TheSnoozer
Copy link
Collaborator

Updated the title due to the fact that the NPE is fixed in the jgit version that was introduced in #203.

@ktoso
Copy link
Collaborator

ktoso commented Mar 26, 2016

Resolved by #233

@ktoso ktoso closed this as completed Mar 26, 2016
@ktoso ktoso added this to the 2.2.1 milestone Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants