Skip to content

Commit 34853f5

Browse files
committed
sweet: reenable gVisor benchmark
The issue preventing the gVisor benchmark from working has magically been resolved by us doing nothing. Yay! Reenable the benchmark. ... Except the startup benchmark, which does `runsc run`, doesn't work on the builders. Womp womp. Disable just that benchmark for now; any coverage here is useful. Fixes #51445. Updates #67508. Change-Id: Ic0bd03038ef392640bf39c801cff2395678a8216 Cq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/586097 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com>
1 parent f862e5e commit 34853f5

File tree

4 files changed

+11
-15
lines changed

4 files changed

+11
-15
lines changed

sweet/benchmarks/gvisor/main.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,17 @@ type benchmark interface {
4444

4545
func main1() error {
4646
benchmarks := []benchmark{
47-
startup{},
47+
// TODO(go.dev/issue/67508): Disable the startup benchmark because it doesn't work
48+
// on the builders.
49+
// startup{},
4850
systemCall{500000},
4951
httpServer{20 * time.Second},
5052
}
5153
if cliCfg.short {
5254
benchmarks = []benchmark{
53-
startup{},
55+
// TODO(go.dev/issue/67508): Disable the startup benchmark because it doesn't work
56+
// on the builders.
57+
// startup{},
5458
systemCall{500},
5559
httpServer{1 * time.Second},
5660
}
@@ -62,8 +66,8 @@ func main1() error {
6266
var buf bytes.Buffer
6367
if err := bench.run(&cliCfg, &buf); err != nil {
6468
if buf.Len() != 0 {
65-
fmt.Fprintln(os.Stderr, "=== Benchmark stdout+stderr ===")
66-
fmt.Fprintln(os.Stderr, buf.String())
69+
fmt.Fprintf(os.Stderr, "=== Benchmark %s stdout+stderr ===", bench.name())
70+
fmt.Fprintf(os.Stderr, "%s\n", buf.String())
6771
}
6872
return err
6973
}

sweet/cmd/sweet/benchmark.go

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -95,19 +95,12 @@ var benchmarkGroups = func() map[string][]*benchmark {
9595
allBenchmarksMap["etcd"],
9696
allBenchmarksMap["go-build"],
9797
allBenchmarksMap["gopher-lua"],
98-
// TODO(go.dev/issue/51445): Enable once gVisor builds with Go 1.19.
99-
// allBenchmarksMap["gvisor"],
98+
allBenchmarksMap["gvisor"],
10099
allBenchmarksMap["markdown"],
101100
allBenchmarksMap["tile38"],
102101
}
103102

104103
for i := range allBenchmarks {
105-
switch allBenchmarks[i].name {
106-
case "gvisor":
107-
// TODO(go.dev/issue/51445): Include in "all"
108-
// once gVisor builds with Go 1.19.
109-
continue
110-
}
111104
m["all"] = append(m["all"], &allBenchmarks[i])
112105
}
113106

sweet/cmd/sweet/integration_test.go

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -200,8 +200,7 @@ func TestSweetEndToEnd(t *testing.T) {
200200
{"bleve-index", 1},
201201
{"gopher-lua", 1},
202202
{"markdown", 1},
203-
// TODO(go.dev/issue/51445): Enable once gVisor builds with Go 1.19.
204-
// {"gvisor", 1},
203+
{"gvisor", 1},
205204
} {
206205
sema.Acquire(context.Background(), shard.weight)
207206
wg.Add(1)

sweet/harnesses/gvisor.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ func (h GVisor) Get(gcfg *common.GetConfig) error {
2929
gcfg.SrcDir,
3030
"https://github.com/google/gvisor",
3131
"go",
32-
"adc7bb5e1baf4a7489e428e1fad756e5e2aa3410", // release-20220228.0-4233-gadc7bb5e1
32+
"b75aeea", // release-20240513.0-37-g4f08fc481
3333
)
3434
}
3535

0 commit comments

Comments
 (0)