Skip to content

Commit 5b4209f

Browse files
committed
crypto/tls: update GREASE-Server-TLS13 BoGo skip
Previously this test was skipped without a comment clarifying why. In practice it's because crypto/tls doesn't generate GREASE extensions at this time, and the test expects to find one in the NewSessionTicket message extensions produced by a server. We're already skipping some other GREASE related test as not-yet-implemented without explicit bogo_config.json exclusion by way of the -enable-grease flag not being implemented, however for TLS 1.3 servers the BoGo expectation is that they _always_ send GREASE, and so the -enable-grease flag isn't provided and an explicit skip must be used. We should revisit this alongside implementing GREASE ext production in general for both clients and servers. Updates #72006 Change-Id: I8af4b555ac8c32cad42215fbf26aa0feae90fa21 Reviewed-on: https://go-review.googlesource.com/c/go/+/650717 Reviewed-by: Roland Shoemaker <roland@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Junyang Shao <shaojunyang@google.com>
1 parent 01688da commit 5b4209f

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/crypto/tls/bogo_config.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"JustConfiguringKyberWorks": "we always send a X25519 key share with Kyber",
5454
"KyberKeyShareIncludedSecond": "we always send the Kyber key share first",
5555
"KyberKeyShareIncludedThird": "we always send the Kyber key share first",
56-
"GREASE-Server-TLS13": "TODO ???",
56+
"GREASE-Server-TLS13": "We don't send GREASE extensions",
5757
"GarbageCertificate*": "TODO ask davidben, alertDecode vs alertBadCertificate",
5858
"SendBogusAlertType": "sending wrong alert type",
5959
"EchoTLS13CompatibilitySessionID": "TODO reject compat session ID",

0 commit comments

Comments
 (0)