Skip to content

Commit 79e01ab

Browse files
committed
cmd/dist: remove windows-amd64-2008 code path
`windows-amd64-2008` builder does no longer exist on go1.20, so it is safe to remove conditions checking for that name. Updates #57003 Closes #56904 Change-Id: I941ccc64cda0af3b9356996c4b581700afa81987 Reviewed-on: https://go-review.googlesource.com/c/go/+/467175 Run-TryBot: Quim Muntal <quimmuntal@gmail.com> Reviewed-by: Bryan Mills <bcmills@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Reviewed-by: Than McIntosh <thanm@google.com>
1 parent c3d3be1 commit 79e01ab

File tree

1 file changed

+1
-8
lines changed

1 file changed

+1
-8
lines changed

src/cmd/dist/test.go

+1-8
Original file line numberDiff line numberDiff line change
@@ -1568,21 +1568,14 @@ func (t *tester) registerRaceTests() {
15681568
// t.registerTest("race:misc/cgo/test", hdr, &goTest{dir: "../misc/cgo/test", race: true, env: []string{"GOTRACEBACK=2"}})
15691569
}
15701570
if t.extLink() {
1571-
var oldWindows rtPreFunc
1572-
if strings.HasPrefix(os.Getenv("GO_BUILDER_NAME"), "windows-amd64-2008") {
1573-
oldWindows.pre = func(*distTest) bool {
1574-
fmt.Println("skipping -race with external linkage on older windows builder, see https://github.com/golang/go/issues/56904 for details")
1575-
return false
1576-
}
1577-
}
15781571
// Test with external linking; see issue 9133.
15791572
t.registerTest("race:external", hdr,
15801573
&goTest{
15811574
race: true,
15821575
ldflags: "-linkmode=external",
15831576
runTests: "TestParse|TestEcho|TestStdinCloseRace",
15841577
pkgs: []string{"flag", "os/exec"},
1585-
}, oldWindows)
1578+
})
15861579
}
15871580
}
15881581

0 commit comments

Comments
 (0)