Skip to content

Commit 8891b82

Browse files
author
Bryan C. Mills
committed
cmd/go: remove a bogus assertion in mod_convert_dep
The removed line assumed that the script's WORK directory is not a child of any directory containing version-control metadata. While that assumption does hold in most cases, it does not hold when, for example, $TMPDIR is $HOME/tmp and $HOME/.git/config exists. A similar situation may or may not arise when using golang.org/x/build/cmd/release. Either way, the assertion is incorrect and was interfering with local testing for #39385. Updates #39385 Fixes #39431 Change-Id: I67813d7ce455aa9b56a6eace6eddebf48d0f7fa6 Reviewed-on: https://go-review.googlesource.com/c/go/+/236818 Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
1 parent 2603d9a commit 8891b82

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/cmd/go/testdata/script/mod_convert_dep.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ cd $WORK/gopkgdir/x
2020
! go list .
2121
stderr 'cannot find main module'
2222
! stderr 'Gopkg.lock'
23-
! stderr 'go mod init'
2423

2524
-- $WORK/test/Gopkg.lock --
2625
-- $WORK/test/x/x.go --

0 commit comments

Comments
 (0)