Skip to content

Commit 971203c

Browse files
committed
cmd/go: remove TestScript/get_unicode and an internal get test case
That test tested that import paths with non-ASCII unicode paths were allowed by the Go command. Remove this test case because golang.org/cl/251878 removes that support. Also rewrite a test case in TestRepoRootForImportPath in the test for cmd/go/internal/get to reflect that unicode directory names are now disallowed. Updates #29101 Change-Id: I669e220facd04fc82ccd05dd08e8f1ff4d48b1fd Reviewed-on: https://go-review.googlesource.com/c/go/+/252297 Run-TryBot: Michael Matloob <matloob@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Bryan C. Mills <bcmills@google.com>
1 parent afa150c commit 971203c

File tree

2 files changed

+2
-45
lines changed

2 files changed

+2
-45
lines changed

src/cmd/go/internal/get/vcs_test.go

+2-5
Original file line numberDiff line numberDiff line change
@@ -32,13 +32,10 @@ func TestRepoRootForImportPath(t *testing.T) {
3232
Repo: "https://github.com/golang/groupcache",
3333
},
3434
},
35-
// Unicode letters in directories (issue 18660).
35+
// Unicode letters in directories are not valid.
3636
{
3737
"github.com/user/unicode/испытание",
38-
&RepoRoot{
39-
vcs: vcsGit,
40-
Repo: "https://github.com/user/unicode",
41-
},
38+
nil,
4239
},
4340
// IBM DevOps Services tests
4441
{

src/cmd/go/testdata/script/get_unicode.txt

-40
This file was deleted.

0 commit comments

Comments
 (0)