Skip to content

Commit b0e7f95

Browse files
committed
crypto/tls: run SkipNewSessionTicket bogo test
This commit removes SkipNewSessionTicket from the bogo_config.json excluded tests list. Previously this test was being skipped with a TODO that there might be a bug here. In practice it seems like there's no bug and the test is handled correctly by crypto/tls. When activated, a TLS 1.2 client connecting to the bogo dispatcher goes through the normal handshake process with the exception that the server skips sending the NewSessionTicket msg expected by the client in response to the client's final flight of handshake msgs. The crypto/tls TLS 1.2 client_handshake.go logic correctly rejects the unexpected message that follows (ChangeCipherSpec) when trying to read the bytes necessary to unmarshal the expected NewSessionTicket message that was omitted. Updates #72006 Change-Id: I9faea4d18589d10b163211aa17b2d0da8af1187e Reviewed-on: https://go-review.googlesource.com/c/go/+/650736 Reviewed-by: Junyang Shao <shaojunyang@google.com> Auto-Submit: Daniel McCarney <daniel@binaryparadox.net> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Roland Shoemaker <roland@golang.org>
1 parent 04164e5 commit b0e7f95

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/crypto/tls/bogo_config.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
"JustConfiguringKyberWorks": "we always send a X25519 key share with Kyber",
5353
"KyberKeyShareIncludedSecond": "we always send the Kyber key share first",
5454
"KyberKeyShareIncludedThird": "we always send the Kyber key share first",
55-
"SkipNewSessionTicket": "TODO confusing? maybe bug",
5655
"SendUserCanceledAlerts*": "TODO may be a real bug?",
5756
"GREASE-Server-TLS13": "TODO ???",
5857
"GarbageCertificate*": "TODO ask davidben, alertDecode vs alertBadCertificate",

0 commit comments

Comments
 (0)