Skip to content

Commit c20b7a0

Browse files
dmitshurgopherbot
authored andcommitted
cmd/dist: use registerStdTestSpecially for normal Go tests only
It was my oversight in CL 463276 to skip registerStdTestSpecially packages in the race bench test registration loop. Package testdir has no benchmarks and doesn't need to be skipped. (And if it had benchmarks, it's very unlikely they'd need any special handling.) By now there are more cmd/cgo/internal/... packages that are registered specially, and there isn't a need for their few benchmarks not to be used for the purpose of race bench tests. If the 3 benchmarks in cmd/cgo/internal/test were to require something special, then we can add it to a new registerRaceBenchTestSpecially map with a comment, and do register them specially in registerTests instead of forgetting to. This restores the automatic 'go_test_bench:cmd/cgo/internal/test' registration and reduces prevalence of registerStdTestSpecially a bit. For #37486. For #56844. Change-Id: I1791fe5bf94cb4b4e0859c5fff4e7a3d5a23723e Reviewed-on: https://go-review.googlesource.com/c/go/+/494656 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Dmitri Shuralyov <dmitshur@golang.org>
1 parent 994eca4 commit c20b7a0

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

src/cmd/dist/test.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -584,9 +584,6 @@ func (t *tester) registerTests() {
584584
}
585585
if t.race {
586586
for _, pkg := range pkgs {
587-
if registerStdTestSpecially[pkg] {
588-
continue
589-
}
590587
if t.packageHasBenchmarks(pkg) {
591588
t.registerRaceBenchTest(pkg)
592589
}

0 commit comments

Comments
 (0)