Skip to content

Commit c40914b

Browse files
committed
cmd/go: convert TestGoBuildARM to the script framework
Part of converting all tests to script framework to improve test parallelism. Updates #36320 Updates #17751 Change-Id: If1e591f28d6399a07b37ed7f4a1419bf7cd915eb Reviewed-on: https://go-review.googlesource.com/c/go/+/214425 Reviewed-by: Jay Conrod <jayconrod@google.com>
1 parent 1c4e515 commit c40914b

File tree

2 files changed

+13
-20
lines changed

2 files changed

+13
-20
lines changed

src/cmd/go/go_test.go

-20
Original file line numberDiff line numberDiff line change
@@ -2117,26 +2117,6 @@ func TestGoBuildGOPATHOrderBroken(t *testing.T) {
21172117
tg.run("install", "-x", "bar")
21182118
}
21192119

2120-
func TestGoBuildARM(t *testing.T) {
2121-
if testing.Short() {
2122-
t.Skip("skipping cross-compile in short mode")
2123-
}
2124-
2125-
tg := testgo(t)
2126-
defer tg.cleanup()
2127-
2128-
tg.makeTempdir()
2129-
tg.cd(tg.path("."))
2130-
2131-
tg.setenv("GOARCH", "arm")
2132-
tg.setenv("GOOS", "linux")
2133-
tg.setenv("GOARM", "5")
2134-
tg.tempFile("hello.go", `package main
2135-
func main() {}`)
2136-
tg.run("build", "hello.go")
2137-
tg.grepStderrNot("unable to find math.a", "did not build math.a correctly")
2138-
}
2139-
21402120
// For issue 14337.
21412121
func TestParallelTest(t *testing.T) {
21422122
tooSlow(t)
+13
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
[short] skip 'skipping cross-compile in short mode'
2+
3+
env GOARCH=arm
4+
env GOOS=linux
5+
env GOARM=5
6+
7+
go build hello.go
8+
! stderr 'unable to find math.a'
9+
10+
-- hello.go --
11+
package main
12+
13+
func main() {}

0 commit comments

Comments
 (0)