regexp: remove unreachable code

ALTree · bradfitz · commit cd41db34bcd1 · 2016-02-23T15:16:50.000Z
Found running go vet on the package. It barks that regexp/backtrack.go:257: unreachable code regexp/backtrack.go:302: unreachable code For #11041 Change-Id: I0f5ba0d6183108fba3d144991b826273db0ffb09 Reviewed-on: https://go-review.googlesource.com/19824 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org>
diff --git a/src/regexp/backtrack.go b/src/regexp/backtrack.go
@@ -254,7 +254,6 @@ func (m *machine) tryBacktrack(b *bitState, i input, pc uint32, pos int) bool {
 
 			}
 			panic("bad arg in InstCapture")
-			continue
 
 		case syntax.InstEmptyWidth:
 			if syntax.EmptyOp(inst.Arg)&^i.context(pos) != 0 {
@@ -299,7 +298,6 @@ func (m *machine) tryBacktrack(b *bitState, i input, pc uint32, pos int) bool {
 			// Otherwise, continue on in hope of a longer match.
 			continue
 		}
-		panic("unreachable")
 	}
 
 	return m.matched

Original file line number	Diff line number	Diff line change
`@@ -254,7 +254,6 @@ func (m machine) tryBacktrack(b bitState, i input, pc uint32, pos int) bool {`
`254`	`254`
`255`	`255`	`}`
`256`	`256`	`panic("bad arg in InstCapture")`
`257`		`- continue`
`258`	`257`
`259`	`258`	`case syntax.InstEmptyWidth:`
`260`	`259`	`if syntax.EmptyOp(inst.Arg)&^i.context(pos) != 0 {`
`@@ -299,7 +298,6 @@ func (m machine) tryBacktrack(b bitState, i input, pc uint32, pos int) bool {`
`299`	`298`	`// Otherwise, continue on in hope of a longer match.`
`300`	`299`	`continue`
`301`	`300`	`}`
`302`		`- panic("unreachable")`
`303`	`301`	`}`
`304`	`302`
`305`	`303`	`return m.matched`