Skip to content

Commit f5526b5

Browse files
committed
runtime: skip TestNewOSProc0 with asan and msan
These fail for the same reason as for the race detector, and is the most frequently failing test in both. For #70054. For #64257. For #64256. Change-Id: I3649e58069190b4450f9d4deae6eb8eca5f827a3 Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-asan-clang15,gotip-linux-amd64-msan-clang15 Reviewed-on: https://go-review.googlesource.com/c/go/+/623176 TryBot-Bypass: Michael Knyszek <mknyszek@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
1 parent b813465 commit f5526b5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/runtime/norace_linux_test.go renamed to src/runtime/nosan_linux_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
// Use of this source code is governed by a BSD-style
33
// license that can be found in the LICENSE file.
44

5-
// The file contains tests that cannot run under race detector for some reason.
5+
// The file contains tests that cannot run under race detector (or asan or msan) for some reason.
66
//
7-
//go:build !race
7+
//go:build !race && !asan && !msan
88

99
package runtime_test
1010

@@ -23,7 +23,7 @@ func newOSProcCreated() {
2323
newOSProcDone = true
2424
}
2525

26-
// Can't be run with -race because it inserts calls into newOSProcCreated()
26+
// Can't be run with -race, -asan, or -msan because it inserts calls into newOSProcCreated()
2727
// that require a valid G/M.
2828
func TestNewOSProc0(t *testing.T) {
2929
runtime.NewOSProc0(0x800000, unsafe.Pointer(abi.FuncPCABIInternal(newOSProcCreated)))

0 commit comments

Comments
 (0)