Skip to content

Commit ff6b6c6

Browse files
author
Bryan C. Mills
committed
net: skip tests that use netsh on the windows-arm64-10 builder
These tests sometimes hang on Windows 10 on ARM64, due to what appears to be a platform bug. Since we have not yet observed any such hangs on the windows-arm64-11 builder, I am leaving the tests otherwise enabled on the theory that the platform bug may have been fixed in Windows 11. Fixes #52082 (at least for now). Change-Id: I79161f485b1921f083ebcf01865d6e7b0178ef70 Reviewed-on: https://go-review.googlesource.com/c/go/+/397315 Trust: Bryan Mills <bcmills@google.com> Run-TryBot: Bryan Mills <bcmills@google.com> Reviewed-by: Ian Lance Taylor <iant@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org>
1 parent 434b2a5 commit ff6b6c6

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/net/net_windows_test.go

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import (
88
"bufio"
99
"bytes"
1010
"fmt"
11+
"internal/testenv"
1112
"io"
1213
"os"
1314
"os/exec"
@@ -205,6 +206,13 @@ func runCmd(args ...string) ([]byte, error) {
205206
}
206207

207208
func checkNetsh(t *testing.T) {
209+
if testenv.Builder() == "windows-arm64-10" {
210+
// netsh was observed to sometimes hang on this builder.
211+
// We have not observed failures on windows-arm64-11, so for the
212+
// moment we are leaving the test enabled elsewhere on the theory
213+
// that it may have been a platform bug fixed in Windows 11.
214+
testenv.SkipFlaky(t, 52082)
215+
}
208216
out, err := runCmd("netsh", "help")
209217
if err != nil {
210218
t.Fatal(err)

0 commit comments

Comments
 (0)