Skip to content

doc/go1.9.html: should go/types.Package.Imports behavior change be included? #21622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmitshur opened this issue Aug 25, 2017 · 3 comments
Closed
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge

Comments

@dmitshur
Copy link
Member

(It's not quite clear to me what's the criteria for inclusion of a change to warrant being mentioned in the release notes under the "Minor changes to the library" section (is it documented somewhere?), that's why this is a question.)

https://godoc.org/go/types#Package.Imports changed behavior slightly. In Go 1.8, it was documented as:

Imports returns the list of packages directly imported by pkg; the list is in source order. Package unsafe is excluded.

[...]

In Go 1.9:

Imports returns the list of packages directly imported by pkg; the list is in source order.

[...]

So package unsafe is no longer excluded.

Should this be mentioned in doc/go1.9.html? It would've been saved me some time debugging an unexpected behavior change if I saw it mentioned there, so maybe it'll be helpful to others too.

Related to #20587.
Related to CL 37694. /cc @griesemer @alandonovan

@dmitshur dmitshur added the Documentation Issues describing a change to documentation. label Aug 25, 2017
@dmitshur
Copy link
Member Author

dmitshur commented Sep 6, 2017

Friendly ping.

If the answer is that "no, it shouldn't be mentioned," this issue can be closed (but I'd like to know why not).

@ianlancetaylor
Copy link
Contributor

Ping @griesemer

@ianlancetaylor
Copy link
Contributor

Whatever we should have done, the ship has sailed and sunk.

@golang golang locked and limited conversation to collaborators Mar 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge
Projects
None yet
Development

No branches or pull requests

3 participants