-
Notifications
You must be signed in to change notification settings - Fork 18k
late call expansion asserts on randomly generated test cases #42236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
PS your horrifying test case also compiles w/o incident for ppc64le, arm, 386, and mips/softfloat. |
Sorry-- since filing the bug I have been messing with the testcase generator to add support for blank params and struct fields, so most likely it is not emitting quite the same code with that seed. Here's a reduced case for one of the failures:
That should produce "internal compiler error: 'Test1': Did not expect to find IDATA-immediate with non-trivial struct/array in it" on master at tip. I'll see about sifting through the unpleasant code and creating (somewhat) minimized test cases. |
Got it, cause is insufficiently imaginative (in terms of likely pathologies) code I fixed in a CL that I am about to submit, that is happy with your example. The bad case:
versus, done right, same function, for structures:
I.e., the array case should have recurred. The new code (refactored, combined, renamed, sorry for all the changes):
|
Change https://golang.org/cl/262117 mentions this issue: |
What version of Go are you using (
go version
)?Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?go env
OutputWhat did you do?
Download this test case generator and run to emit code. This will emit a series of randomly generated Go functions into the dir /tmp/cabi-testgen/cabi-testgen/x:
What did you expect to see?
Clean build
What did you see instead?
The text was updated successfully, but these errors were encountered: