x/tools/gopls: recent updates made VS Code colors broken

[inliquid]

1. VS Code
2. go1.16.4
3. gopls@master

Here is what it looks like on gopls@latest (v0.6.11):

Here is what it looks like on gopls@master (installed with go install):

[stamblerre]

The change that caused this was https://golang.org/cl/323169, which enables semantic tokens through the LSP rather than through VS Code's default textmate grammar. This implementation follows the LSP specification of the semantic tokens feature, which does not allow the server to specify any specific colors.

It seems possible that your color theme may not support this feature well. For example, I see different colors for log.Printf with my theme, and it seems like yours uses an underline instead. I would suggest filing an issue about the theme, if you don't like it, or switching to a different one.

[stamblerre]

You can also disable the semantic tokens feature through the

	"gopls": {
		"ui.semanticTokens": true
        }

setting, but note that we do intend to deprecate the original grammar in the future.

[inliquid]

I'm using standard "Monokai" color theme of VS Code. You can switch it easily back and forth in VS Code command prompt. Please also note that there is no highlighting of formatting verbs %s, %v and special symbols, such as \n, which degrades user experience quite significantly when working with strings.

Is there any way to stick to old scheme?

[stamblerre]

See #45753 for the semantic tokens for formatting verbs--we will work on addressing that soon. And you can get the old implementation back by setting:

"gopls": {
	"ui.semanticTokens": false
}

[stamblerre]

Duplicate of #45753