cmd/go: go env incorrect quoting for values with double quotes

[seankhliao]

What version of Go are you using (go version)?

» go version                  
go version devel go1.21-b35ee3b0467 Wed Mar 1 14:25:13 2023 +0000 linux/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

go env Output

» go env       
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/user/.cache/go-build"
GOENV="/home/user/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS="-trimpath "-ldflags=-s -w""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/user/.data/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/user/.data/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/user/sdk/gotip"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/user/sdk/gotip/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel go1.21-b35ee3b0467 Wed Mar 1 14:25:13 2023 +0000"
GCCGO="gccgo"
GOAMD64="v3"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="0"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build547532058=/tmp/go-build -gno-record-gcc-switches"

What did you do?

» go env -w GOFLAGS='-trimpath "-ldflags=-s -w"'

» go env | grep GOFLAGS                         
GOFLAGS="-trimpath "-ldflags=-s -w""

What did you expect to see?

GOFLAGS='-trimpath "-ldflags=-s -w"'

or

GOFLAGS="-trimpath \"-ldflags=-s -w\""

What did you see instead?

incorrect quoting of values with double quotes

[seankhliao]

cc @bcmills @matloob

[bcmills]

Yep, that's wrong. 😩

The bug is here:
https://cs.opensource.google/go/go/+/master:src/cmd/go/internal/envcmd/env.go;l=418;drc=db259cdd80eff527e8f344d678031c516167d258

We have a quoted.Join function that is used elsewhere in envcmd/env.go. It should probably be used in PrintEnv as well.

[cuishuang]

If you don't mind, I'd like to fix this bug.

[gopherbot]

Change https://go.dev/cl/473895 mentions this issue: cmd/go: fix incorrect quoting for values with double quotes

[seankhliao]

Fixed in CL 488375