Skip to content

Commit 48e5bd1

Browse files
committed
internal/lsp: add titles to go mod tidy and update go.sum fixes
These were missing titles, which was showing up empty for users in the VS Code UI and leading people not to trust the fixes. Also did a find references on SuggestedFix to confirm that we always set the title in other cases. Fixes golang/go#43234 Change-Id: I8d0f272c383a2e1a364aefcec6650988d18d4fb4 Reviewed-on: https://go-review.googlesource.com/c/tools/+/278778 Trust: Rebecca Stambler <rstambler@golang.org> Run-TryBot: Rebecca Stambler <rstambler@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Go Bot <gobot@golang.org> Reviewed-by: Robert Findley <rfindley@google.com>
1 parent fa10ef0 commit 48e5bd1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

internal/lsp/cache/mod_tidy.go

+2
Original file line numberDiff line numberDiff line change
@@ -209,13 +209,15 @@ See https://github.com/golang/go/issues/39164 for more detail on this issue.`,
209209
Message: `go.sum is out of sync with go.mod. Please update it or run "go mod tidy".`,
210210
SuggestedFixes: []source.SuggestedFix{
211211
{
212+
Title: source.CommandTidy.Title,
212213
Command: &protocol.Command{
213214
Command: source.CommandTidy.ID(),
214215
Title: source.CommandTidy.Title,
215216
Arguments: args,
216217
},
217218
},
218219
{
220+
Title: source.CommandUpdateGoSum.Title,
219221
Command: &protocol.Command{
220222
Command: source.CommandUpdateGoSum.ID(),
221223
Title: source.CommandUpdateGoSum.Title,

0 commit comments

Comments
 (0)