internal/completion: default to regular completion for f.Fuzz without f.Add

pjweinbgo · pjweinbgo · commit 77aa08bb151a · 2022-03-16T01:41:57.000Z
Change-Id: I7a05dba3f4a68c2075ebdf078e9e0ee6cfd97f28 Reviewed-on: https://go-review.googlesource.com/c/tools/+/393019 Run-TryBot: Peter Weinberger <pjw@google.com> gopls-CI: kokoro <noreply+kokoro@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Trust: Peter Weinberger <pjw@google.com> Reviewed-by: Robert Findley <rfindley@google.com>
diff --git a/internal/lsp/source/completion/fuzz.go b/internal/lsp/source/completion/fuzz.go
@@ -100,7 +100,9 @@ Loop:
 		}
 		ast.Inspect(n, f)
 		if add == nil {
-			return true
+			// looks like f.Fuzz without a preceding f.Add.
+			// let the regular completion handle it.
+			return false
 		}
 
 		lbl := "Fuzz(func(t *testing.T"

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,9 @@ Loop:`
`100`	`100`	`}`
`101`	`101`	`ast.Inspect(n, f)`
`102`	`102`	`if add == nil {`
`103`		`- return true`
	`103`	`+ // looks like f.Fuzz without a preceding f.Add.`
	`104`	`+ // let the regular completion handle it.`
	`105`	`+ return false`
`104`	`106`	`}`
`105`	`107`
`106`	`108`	`lbl := "Fuzz(func(t *testing.T"`