Skip to content

Commit 1cc1b7c

Browse files
Pavle Leehyangah
Pavle Lee
authored andcommitted
src/goGenerateTests: fix method can not generate test in gopls document symbol
Gopls's document symbol provider classifies methods correctly, while `go-outline`-based document symbol provider marks them as "function". The difference caused regression after change for #1020. Fixes #2091 Change-Id: I1b92753132be26b528f994ae42af32c723dd7ce2 GitHub-Last-Rev: 6483108 GitHub-Pull-Request: #2090 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/389994 Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com> Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com> Trust: Suzy Mueller <suzmue@golang.org>
1 parent aca26c6 commit 1cc1b7c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/goGenerateTests.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,5 +227,5 @@ function generateTests(conf: Config, goConfig: vscode.WorkspaceConfiguration): P
227227
async function getFunctions(doc: vscode.TextDocument): Promise<vscode.DocumentSymbol[]> {
228228
const documentSymbolProvider = new GoDocumentSymbolProvider();
229229
const symbols = await documentSymbolProvider.provideDocumentSymbols(doc, null);
230-
return symbols[0].children.filter((sym) => sym.kind === vscode.SymbolKind.Function);
230+
return symbols[0].children.filter((sym) => [vscode.SymbolKind.Function, vscode.SymbolKind.Method].includes(sym.kind));
231231
}

0 commit comments

Comments
 (0)