add more testcases

Author: firefart

.golangci.example.yml

@@ -790,7 +790,7 @@ linters-settings:
       - lostcancel
       - nilfunc
       - nilness
-      - nonamedreturnlint
+      - nonamedreturns
       - printf
       - reflectvaluecompare
       - shadow
@@ -834,7 +834,7 @@ linters-settings:
       - lostcancel
       - nilfunc
       - nilness
-      - nonamedreturnlint
+      - nonamedreturns
       - printf
       - reflectvaluecompare
       - shadow

go.mod

@@ -23,7 +23,7 @@ require (
 	github.com/denis-tingaikin/go-header v0.4.3
 	github.com/esimonov/ifshort v1.0.4
 	github.com/fatih/color v1.13.0
-	github.com/firefart/nonamedreturnlint v1.0.0
+	github.com/firefart/nonamedreturns v1.0.0
 	github.com/fzipp/gocyclo v0.5.0
 	github.com/go-critic/go-critic v0.6.2
 	github.com/go-xmlfmt/xmlfmt v0.0.0-20191208150333-d5b6f63a941b
@@ -162,7 +162,7 @@ require (
 	github.com/yusufpapurcu/wmi v1.2.2 // indirect
 	golang.org/x/mod v0.6.0-dev.0.20220106191415-9b9b3d81d5e3 // indirect
 	golang.org/x/sync v0.0.0-20210220032951-036812b2e83c // indirect
-	golang.org/x/sys v0.0.0-20220330033206-e17cdc41300f // indirect
+	golang.org/x/sys v0.0.0-20220403020550-483a9cbc67c0 // indirect
 	golang.org/x/text v0.3.7 // indirect
 	golang.org/x/xerrors v0.0.0-20200804184101-5ec99f83aff1 // indirect
 	google.golang.org/protobuf v1.27.1 // indirect

go.sum

@@ -1,15 +1,15 @@
 package golinters
 
 import (
-	"github.com/firefart/nonamedreturnlint/analyzer"
+	"github.com/firefart/nonamedreturns/analyzer"
 	"golang.org/x/tools/go/analysis"
 
 	"github.com/golangci/golangci-lint/pkg/golinters/goanalysis"
 )
 
-func NewNoNamedReturnLint() *goanalysis.Linter {
+func NewNoNamedReturns() *goanalysis.Linter {
 	return goanalysis.NewLinter(
-		"nonamedreturnlint",
+		"nonamedreturns",
 		"Reports all named returns",
 		[]*analysis.Analyzer{analyzer.Analyzer},
 		nil,

pkg/golinters/nonamedreturnlint.go renamed to pkg/golinters/nonamedreturns.go

@@ -527,10 +527,10 @@ func (m Manager) GetAllSupportedLinterConfigs() []*linter.Config {
 			WithURL("https://github.com/sonatard/noctx").
 			WithNoopFallback(m.cfg),
 
-		linter.NewConfig(golinters.NewNoNamedReturnLint()).
+		linter.NewConfig(golinters.NewNoNamedReturns()).
 			WithSince("v1.46.0").
 			WithPresets(linter.PresetStyle).
-			WithURL("https://github.com/FireFart/nonamedreturnlint"),
+			WithURL("https://github.com/firefart/nonamedreturns"),
 
 		linter.NewConfig(golinters.NewParallelTest()).
 			WithSince("v1.33.0").

pkg/lint/lintersdb/manager.go

@@ -0,0 +1,94 @@
+//args: -Enonamedreturns
+package testdata
+
+import "fmt"
+
+type asdf struct {
+	test string
+}
+
+func noParams() {
+	return
+}
+
+var c = func() {
+	return
+}
+
+var d = func() error {
+	return nil
+}
+
+var e = func() (err error) { // ERROR `named return "err" with type "error" found`
+	err = nil
+	return
+}
+
+var (
+	f = func() {
+		return
+	}
+
+	g = func() error {
+		return nil
+	}
+
+	h = func() (err error) { // ERROR `named return "err" with type "error" found`
+		err = nil
+		return
+	}
+)
+
+// this should not match as the implementation does not need named parameters (see below)
+type funcDefintion func(arg1, arg2 interface{}) (num int, err error)
+
+func funcDefintionImpl(arg1, arg2 interface{}) (int, error) {
+	return 0, nil
+}
+
+func funcDefintionImpl2(arg1, arg2 interface{}) (num int, err error) { // ERROR `named return "num" with type "int" found`
+	return 0, nil
+}
+
+var funcVar = func() (msg string) { // ERROR `named return "msg" with type "string" found`
+	msg = "c"
+	return msg
+}
+
+func test() {
+	a := funcVar()
+	_ = a
+
+	var function funcDefintion
+	function = funcDefintionImpl
+	i, err := function("", "")
+	_ = i
+	_ = err
+	function = funcDefintionImpl2
+	i, err = function("", "")
+	_ = i
+	_ = err
+}
+
+func good(i string) string {
+	return i
+}
+
+func bad(i string, a, b int) (ret1 string, ret2 interface{}, ret3, ret4 int, ret5 asdf) { // ERROR `named return "ret1" with type "string" found`
+	x := "dummy"
+	return fmt.Sprintf("%s", x), nil, 1, 2, asdf{}
+}
+
+func bad2() (msg string, err error) { // ERROR `named return "msg" with type "string" found`
+	msg = ""
+	err = nil
+	return
+}
+
+func myLog(format string, args ...interface{}) {
+	return
+}
+
+type obj struct{}
+
+func (o *obj) func1() (err error) { return nil } // ERROR `named return "err" with type "error" found`