BrowserContext can't be created for reused VUs #4275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
inancgumus and
oleiade
and removed request for
a team
olegbespalov
approved these changes
Jan 28, 2025
inancgumus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix browser test on reused VUs.
This also techinically fixes being able to use browser on reused browser VUs that are not in browser scenarios.
Why?
While a rare case, reusing VUs is still part of k6.
The cost currently seems to be around 33% performance for empty iterations.
But if I do http.get to not open port it dissapears so I would expect for any real world scripts this is a none issue.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)