Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return a meaningful errors if agent cannot connect upstream host #252

Closed
pablochacin opened this issue Jul 11, 2023 · 0 comments · Fixed by #271
Closed

Return a meaningful errors if agent cannot connect upstream host #252

pablochacin opened this issue Jul 11, 2023 · 0 comments · Fixed by #271
Assignees
Labels
enhancement New feature or request

Comments

@pablochacin
Copy link
Collaborator

Presently, when the agent gets an error connecting to the upstream host (the one it has to forward for), it returns an internal server error.

This may be confusing, as the internal server is a common fault to inject in a test. Actually, it happens in e2e tests that inject this error and the pass even if the agent fails to connect the upstream host because it is returning this error, instead of reporting it had an issue completing the request.

Therefore, it would be convenient that in this situation the agent returns a meaningful error such as 'bad gateway' to indicate there was an issue connecting to the upstream service.

@pablochacin pablochacin added the enhancement New feature or request label Jul 11, 2023
@nadiamoe nadiamoe self-assigned this Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants