Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for fault injection in Service Disruptor #261

Closed
pablochacin opened this issue Jul 24, 2023 · 1 comment · Fixed by #356
Closed

Add unit tests for fault injection in Service Disruptor #261

pablochacin opened this issue Jul 24, 2023 · 1 comment · Fixed by #356

Comments

@pablochacin
Copy link
Collaborator

pablochacin commented Jul 24, 2023

Initially, the ServiceDisruptor was implemented as a wrapper of a PodDisruptor (created using the service's selector to create the PodSelector). The ServiceDisruptor's fault injection methods simply passed the arguments down to the respective PodDisruptor methods and therefore did not have any unit test.

The current implementation has diverged and now the ServiceDisruptor has its own logic for fault injection that should be tested to detect faults such as #260.

@pablochacin
Copy link
Collaborator Author

Blocked by #301

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant