Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build for non-release versions is fails #268

Closed
pablochacin opened this issue Jul 31, 2023 · 0 comments · Fixed by #269
Closed

Build for non-release versions is fails #268

pablochacin opened this issue Jul 31, 2023 · 0 comments · Fixed by #269
Labels
bug Something isn't working ci/cd

Comments

@pablochacin
Copy link
Collaborator

#265 changed the way the kx6-disruptor go package version is set when building the custom k6 binary.

The logic now takes the package version passed to the build-package.sh command.

In the CI, this command receives the package version as defined in the build job, that for non-release versions (e.g. pr merge) the package version is set to devel-<commit>.

As a result, the build fails:

replace github.com/grafana/xk6-disruptor: version "dev-4434c64" invalid: unknown revision dev-4434c64
@pablochacin pablochacin added bug Something isn't working ci/cd labels Jul 31, 2023
@pablochacin pablochacin mentioned this issue Aug 1, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci/cd
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant