Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(product): deprecate best sellers #3461

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
xelaint Elain T.
@griest024 griest024 added the package: product @daffodil/product label Jan 23, 2025
@griest024 griest024 self-assigned this Jan 23, 2025
@griest024 griest024 requested a review from a team as a code owner January 23, 2025 16:08
Copy link
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you flag in what version these should be removed?

@griest024
Copy link
Member Author

Can you flag in what version these should be removed?

The script will do that automatically

@griest024 griest024 merged commit 13f40a4 into graycoreio:develop Jan 27, 2025
29 checks passed
@gray-bot gray-bot mentioned this pull request Jan 27, 2025
@griest024 griest024 deleted the feat/product/driver/deprecate-best-sellers branch February 4, 2025 16:18
leozhang14 pushed a commit to leozhang14/daffodil that referenced this pull request Feb 9, 2025

Verified

This commit was signed with the committer’s verified signature. The key has expired.
xelaint Elain T.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: product @daffodil/product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants