btcjson+rpcclient: restore bitcoind compatibility

guggero · guggero · commit a73574156058 · 2020-11-12T10:41:00.000+01:00
The PR btcsuite#1594 introduced a change that made the order of parameters relevant, if one of them is nil. This makes it harder to be backward compatible with the same JSON message if an existing parameter in bitcoind was re-purposed to have a different meaning.
diff --git a/btcjson/chainsvrcmds.go b/btcjson/chainsvrcmds.go
@@ -822,8 +822,8 @@ func NewSearchRawTransactionsCmd(address string, verbose, skip, count *int, vinE
 // SendRawTransactionCmd defines the sendrawtransaction JSON-RPC command.
 type SendRawTransactionCmd struct {
 	HexTx         string
-	AllowHighFees *bool `jsonrpcdefault:"false"`
 	MaxFeeRate    *int32
+	AllowHighFees *bool `jsonrpcdefault:"false"`
 }
 
 // NewSendRawTransactionCmd returns a new instance which can be used to issue a

Original file line number	Diff line number	Diff line change
`@@ -822,8 +822,8 @@ func NewSearchRawTransactionsCmd(address string, verbose, skip, count *int, vinE`
`822`	`822`	`// SendRawTransactionCmd defines the sendrawtransaction JSON-RPC command.`
`823`	`823`	`type SendRawTransactionCmd struct {`
`824`	`824`	`HexTx string`
`825`		- AllowHighFees *bool `jsonrpcdefault:"false"`
`826`	`825`	`MaxFeeRate *int32`
	`826`	+ AllowHighFees *bool `jsonrpcdefault:"false"`
`827`	`827`	`}`
`828`	`828`
`829`	`829`	`// NewSendRawTransactionCmd returns a new instance which can be used to issue a`