Skip to content

Ability to add multiple armor stands to the scene #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Greg-J opened this issue Dec 7, 2020 · 6 comments
Open

Ability to add multiple armor stands to the scene #34

Greg-J opened this issue Dec 7, 2020 · 6 comments

Comments

@Greg-J
Copy link

Greg-J commented Dec 7, 2020

It's crazy to me the only complete tool for armorstand posing is a web project, but here we are.

Great work, by the way.

What would be phenomenal is to abstract the armor-stand away from the scene and allow for multiple armor stands to be placed / positioned.

@haselkern
Copy link
Owner

Sounds nice! Would be a big undertaking though, as several things would need to change. The armorstand would need to be encapsulated and the user interface would need to be more flexible to work with different armorstands.
I finally brought myself to create #35, so a rewrite which might include this functionality might drop in a few months.

@Greg-J
Copy link
Author

Greg-J commented Dec 8, 2020

And this is why we make everything a class ;)

In all seriousness, that's great. If you're looking for a hand, let me know. I'd be happy to get involved.

A timeline for simple animation would be a nice feature as well.

@haselkern
Copy link
Owner

How do you suppose a timeline would work? Should the website generate a command to spawn command blocks that make the animation happen?
I will lay the foundation for the rewrite in the following weeks and will definitely notify you should I need any help :)

@thelennylord
Copy link
Collaborator

I like the idea of adding a timeline for animations. However, I think we should instead generate data packs rather than a one command generator since the latter has been replaced by data packs due to their efficiency and flexibility. This would also allow developers to integrate the animations into their projects easily.

@Greg-J
Copy link
Author

Greg-J commented Dec 9, 2020

Absolutely agree @thelennylord. The scene could include a player actor that indicates where the command will be run from and subsequently, where the scene will be drawn in reference to that point.

As for the timeline @thelennylord, There is an older example here of what that could look like. That example over-complicates it with the interpolation option though when really, a timeline this simple should always interpolate.

For instance:

Let's say I wanted a waving armorstand. I set a keyframe at tick 1 of the arm in the position of the start of the waive. I then would set a keyframe at tick 20 of the arm in the position at the end of the waive. Then another keyframe at tick 39 of the arm back back at the beginning of the waive. This would give us a looped waiving animation.

I'm a usability designer by trade. I'd be happy to help with the usability and interface.

@Mortimer-Kerman
Copy link

Yeah this could be amazing!
Upvote!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants