Skip to content

Commit 2f28373

Browse files
bfladbflad
committed
tests: Switch to hashicorptest.com DNS records for testing
Reference: #112 Reference: #144 Reference: #154 Reference: #157
1 parent 691cc95 commit 2f28373

7 files changed

+47
-45
lines changed

‎internal/provider/data_dns_a_record_set_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ func TestAccDataDnsARecordSet_Basic(t *testing.T) {
1515
{
1616
Config: `
1717
data "dns_a_record_set" "test" {
18-
host = "127.0.0.1.nip.io"
18+
host = "terraform-provider-dns-a.hashicorptest.com"
1919
}
2020
`,
2121
Check: resource.ComposeAggregateTestCheckFunc(
2222
resource.TestCheckResourceAttr(recordName, "addrs.#", "1"),
2323
resource.TestCheckTypeSetElemAttr(recordName, "addrs.*", "127.0.0.1"),
24-
resource.TestCheckResourceAttr(recordName, "id", "127.0.0.1.nip.io"),
24+
resource.TestCheckResourceAttr(recordName, "id", "terraform-provider-dns-a.hashicorptest.com"),
2525
),
2626
},
2727
},

‎internal/provider/data_dns_aaaa_record_set_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ func TestAccDataDnsAAAARecordSet_Basic(t *testing.T) {
1515
{
1616
Config: `
1717
data "dns_aaaa_record_set" "test" {
18-
host = "example.com"
18+
host = "terraform-provider-dns-aaaa.hashicorptest.com"
1919
}
2020
`,
2121
Check: resource.ComposeAggregateTestCheckFunc(
2222
resource.TestCheckResourceAttr(recordName, "addrs.#", "1"),
23-
resource.TestCheckTypeSetElemAttr(recordName, "addrs.*", "2606:2800:220:1:248:1893:25c8:1946"),
24-
resource.TestCheckResourceAttr(recordName, "id", "example.com"),
23+
resource.TestCheckTypeSetElemAttr(recordName, "addrs.*", "::1"),
24+
resource.TestCheckResourceAttr(recordName, "id", "terraform-provider-dns-aaaa.hashicorptest.com"),
2525
),
2626
},
2727
},

‎internal/provider/data_dns_cname_record_set_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ func TestAccDataDnsCnameRecordSet_Basic(t *testing.T) {
1515
{
1616
Config: `
1717
data "dns_cname_record_set" "test" {
18-
host = "www.hashicorp.com"
18+
host = "terraform-provider-dns-cname.hashicorptest.com"
1919
}
2020
`,
2121
Check: resource.ComposeAggregateTestCheckFunc(
22-
resource.TestCheckResourceAttr(recordName, "cname", "cname.vercel-dns.com."),
23-
resource.TestCheckResourceAttr(recordName, "id", "www.hashicorp.com"),
22+
resource.TestCheckResourceAttr(recordName, "cname", "example.com."),
23+
resource.TestCheckResourceAttr(recordName, "id", "terraform-provider-dns-cname.hashicorptest.com"),
2424
),
2525
},
2626
},

‎internal/provider/data_dns_mx_record_set_test.go

Lines changed: 4 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -15,32 +15,16 @@ func TestAccDataDnsMXRecordSet_Basic(t *testing.T) {
1515
{
1616
Config: `
1717
data "dns_mx_record_set" "test" {
18-
domain = "google.com"
18+
domain = "terraform-provider-dns-mx.hashicorptest.com"
1919
}
2020
`,
2121
Check: resource.ComposeAggregateTestCheckFunc(
22-
resource.TestCheckResourceAttr(recordName, "id", "google.com"),
23-
resource.TestCheckResourceAttr(recordName, "mx.#", "5"),
22+
resource.TestCheckResourceAttr(recordName, "id", "terraform-provider-dns-mx.hashicorptest.com"),
23+
resource.TestCheckResourceAttr(recordName, "mx.#", "1"),
2424
resource.TestCheckTypeSetElemNestedAttrs(recordName, "mx.*", map[string]string{
25-
"exchange": "aspmx.l.google.com.",
25+
"exchange": "example.com.",
2626
"preference": "10",
2727
}),
28-
resource.TestCheckTypeSetElemNestedAttrs(recordName, "mx.*", map[string]string{
29-
"exchange": "alt1.aspmx.l.google.com.",
30-
"preference": "20",
31-
}),
32-
resource.TestCheckTypeSetElemNestedAttrs(recordName, "mx.*", map[string]string{
33-
"exchange": "alt2.aspmx.l.google.com.",
34-
"preference": "30",
35-
}),
36-
resource.TestCheckTypeSetElemNestedAttrs(recordName, "mx.*", map[string]string{
37-
"exchange": "alt3.aspmx.l.google.com.",
38-
"preference": "40",
39-
}),
40-
resource.TestCheckTypeSetElemNestedAttrs(recordName, "mx.*", map[string]string{
41-
"exchange": "alt4.aspmx.l.google.com.",
42-
"preference": "50",
43-
}),
4428
),
4529
},
4630
},

‎internal/provider/data_dns_ns_record_set_test.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,13 @@ func TestAccDataDnsNSRecordSet_Basic(t *testing.T) {
1515
{
1616
Config: `
1717
data "dns_ns_record_set" "test" {
18-
host = "terraform.io"
18+
host = "terraform-provider-dns-ns.hashicorptest.com"
1919
}
2020
`,
2121
Check: resource.ComposeAggregateTestCheckFunc(
22-
resource.TestCheckResourceAttr(recordName, "id", "terraform.io"),
23-
resource.TestCheckResourceAttr(recordName, "nameservers.#", "2"),
24-
resource.TestCheckTypeSetElemAttr(recordName, "nameservers.*", "sam.ns.cloudflare.com."),
25-
resource.TestCheckTypeSetElemAttr(recordName, "nameservers.*", "zara.ns.cloudflare.com."),
22+
resource.TestCheckResourceAttr(recordName, "id", "terraform-provider-dns-ns.hashicorptest.com"),
23+
resource.TestCheckResourceAttr(recordName, "nameservers.#", "1"),
24+
resource.TestCheckTypeSetElemAttr(recordName, "nameservers.*", "ns.cloudflare.com."),
2625
),
2726
},
2827
},

‎internal/provider/data_dns_srv_record_set_test.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,17 @@ func TestAccDataDnsSRVRecordSet_Basic(t *testing.T) {
1515
{
1616
Config: `
1717
data "dns_srv_record_set" "test" {
18-
service = "_http._tcp.mxtoolbox.com"
18+
service = "terraform-provider-dns-srv.hashicorptest.com"
1919
}
2020
`,
2121
Check: resource.ComposeAggregateTestCheckFunc(
22-
resource.TestCheckResourceAttr(recordName, "id", "_http._tcp.mxtoolbox.com"),
22+
resource.TestCheckResourceAttr(recordName, "id", "terraform-provider-dns-srv.hashicorptest.com"),
2323
resource.TestCheckResourceAttr(recordName, "srv.#", "1"),
2424
resource.TestCheckTypeSetElemNestedAttrs(recordName, "srv.*", map[string]string{
25-
"port": "80",
26-
"priority": "10",
27-
"target": "mxtoolbox.com.",
28-
"weight": "100",
25+
"port": "443",
26+
"priority": "0",
27+
"target": "example.com.",
28+
"weight": "0",
2929
}),
3030
),
3131
},

‎internal/provider/data_dns_txt_record_set_test.go

Lines changed: 25 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,38 @@
11
package provider
22

33
import (
4-
"os"
54
"regexp"
65
"testing"
76

87
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
98
)
109

1110
func TestAccDataDnsTxtRecordSet_Basic(t *testing.T) {
12-
// KEM: This test does not work in the GitHub Actions runner, although
13-
// it passes locally and on Travis. More investigation needed.
14-
if isInGitHubActions := os.Getenv("GITHUB_ACTIONS"); isInGitHubActions == "true" {
15-
t.Skip()
16-
}
11+
recordName := "data.dns_txt_record_set.test"
12+
13+
resource.UnitTest(t, resource.TestCase{
14+
Providers: testAccProviders,
15+
Steps: []resource.TestStep{
16+
{
17+
Config: `
18+
data "dns_txt_record_set" "test" {
19+
host = "terraform-provider-dns-txt.hashicorptest.com"
20+
}
21+
`,
22+
Check: resource.ComposeAggregateTestCheckFunc(
23+
resource.TestCheckResourceAttr(recordName, "id", "terraform-provider-dns-txt.hashicorptest.com"),
24+
resource.TestCheckResourceAttr(recordName, "record", "v=spf1 -all"),
25+
resource.TestCheckResourceAttr(recordName, "records.#", "1"),
26+
resource.TestCheckTypeSetElemAttr(recordName, "records.*", "v=spf1 -all"),
27+
),
28+
},
29+
},
30+
})
31+
}
32+
33+
func TestAccDataDnsTxtRecordSet_512Byte(t *testing.T) {
34+
t.Skipf("TODO: Large TXT record handling (greater than 512 bytes) will return errors in some environments. Reference: https://github.com/hashicorp/terraform-provider-dns/issues/157")
35+
1736
recordName := "data.dns_txt_record_set.test"
1837

1938
resource.UnitTest(t, resource.TestCase{

0 commit comments

Comments
 (0)