-
Notifications
You must be signed in to change notification settings - Fork 199
Package tags get reset when a new version is uploaded #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Confirmed. Still there. Prod. ;) |
Still reset to default on each upload. It would be cool if you could include hackage-tags.txt in your extra-source-files. Or have a tags field in the project .cabal file (not sure how closely this project integrates with cabal-install, but assume it's tightly, since hackage seems to host only cabalised repos?). Maybe this should be fixed, to encourage the use of tags, which add a lot of value for the amount of work required of the uploader. Would a patch be given serious consideration? |
Looks like the same logic is still there? Should be an easy enough fix -- take a look at https://github.com/haskell/hackage-server/blob/master/Distribution/Server/Features/Tags.hs#L96 |
Ugh, I think this was never fixed! |
This appears to keep happening, so I'm reopening. We need to investigate further. |
I wasn't able to reproduce this. @gbaz do you mean it keeps happening randomly/intermittently? |
I think it is ok on package upload, but may fail now on server restart.
|
This is because the (necessary) packageChangeHook in the Tags feature calls SetPackageTags disregarding existing tags. This is perhaps not critical to fix until tags are widely editable (not just by maintainers), and there's a good story for tags.
The text was updated successfully, but these errors were encountered: