Skip to content

Package tags get reset when a new version is uploaded #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gracenotes opened this issue Sep 25, 2013 · 7 comments
Open

Package tags get reset when a new version is uploaded #80

gracenotes opened this issue Sep 25, 2013 · 7 comments

Comments

@gracenotes
Copy link
Contributor

This is because the (necessary) packageChangeHook in the Tags feature calls SetPackageTags disregarding existing tags. This is perhaps not critical to fix until tags are widely editable (not just by maintainers), and there's a good story for tags.

@Mikolaj
Copy link
Member

Mikolaj commented Dec 14, 2013

Confirmed. Still there. Prod. ;)

@obligatory
Copy link

Still reset to default on each upload.

It would be cool if you could include hackage-tags.txt in your extra-source-files. Or have a tags field in the project .cabal file (not sure how closely this project integrates with cabal-install, but assume it's tightly, since hackage seems to host only cabalised repos?).

Maybe this should be fixed, to encourage the use of tags, which add a lot of value for the amount of work required of the uploader. Would a patch be given serious consideration?

@gbaz
Copy link
Contributor

gbaz commented Oct 5, 2015

Looks like the same logic is still there? Should be an easy enough fix -- take a look at https://github.com/haskell/hackage-server/blob/master/Distribution/Server/Features/Tags.hs#L96

@gbaz
Copy link
Contributor

gbaz commented Jan 28, 2018

Ugh, I think this was never fixed!

@gbaz gbaz self-assigned this Jan 28, 2018
@hvr hvr closed this as completed in #660 Feb 3, 2018
@gbaz
Copy link
Contributor

gbaz commented Jan 23, 2019

This appears to keep happening, so I'm reopening. We need to investigate further.

@gbaz gbaz reopened this Jan 23, 2019
@mitchellwrosen
Copy link
Contributor

I wasn't able to reproduce this. @gbaz do you mean it keeps happening randomly/intermittently?

@gbaz
Copy link
Contributor

gbaz commented Mar 9, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants