Skip to content

Commit 530dd4e

Browse files
committed
clean up
1 parent f6b7d77 commit 530dd4e

File tree

2 files changed

+0
-12
lines changed

2 files changed

+0
-12
lines changed

ghcide/src/Development/IDE/Plugin/HLS.hs

-1
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,6 @@ extensibleNotificationPlugins defaultConfig xs = Plugin mempty handlers
173173
handlers = mconcat $ do
174174
(IdeNotification m :=> IdeNotificationHandler fs') <- DMap.assocs handlers'
175175
pure $ notificationHandler m $ \ide params -> do
176-
liftIO $ logInfo (ideLogger ide) "extensibleNotificationPlugins handler entered"
177176
config <- fromMaybe defaultConfig <$> Ide.PluginUtils.getClientConfig
178177
let fs = filter (\(pid,_) -> pluginEnabledNotification m pid config) fs'
179178
case nonEmpty fs of

hls-plugin-api/src/Ide/Types.hs

-11
Original file line numberDiff line numberDiff line change
@@ -236,20 +236,9 @@ newtype PluginHandler a (m :: Method FromClient Request)
236236

237237
newtype PluginNotificationHandler a (m :: Method FromClient Notification)
238238
= PluginNotificationHandler (PluginId -> a -> MessageParams m -> LspM Config ())
239-
-- newtype PluginNotificationHandler a (m :: Method FromClient Notification)
240-
-- = PluginNotificationHandler (PluginNotificationMethodHandler a m)`
241-
242-
{-
243-
From Zubin
244-
alanz_: I would say `newtype PluginNotificationHandler a (m :: Method FromClient Notification) = PluginNotificationHandler (PluginNotificationMethodHandler a m)`
245-
16:28 and `newtype PluginNotificationHandlers a = PluginNotificationHandlers (DMap SMethod (PluginNotificationHandler a))
246-
247-
-}
248239

249240
newtype PluginHandlers a = PluginHandlers (DMap IdeMethod (PluginHandler a))
250241
newtype PluginNotificationHandlers a = PluginNotificationHandlers (DMap IdeNotification (PluginNotificationHandler a))
251-
-- newtype PluginNotificationHandlers a = PluginNotificationHandlers (DMap SMethod (PluginNotificationHandler a))
252-
253242
instance Semigroup (PluginHandlers a) where
254243
(PluginHandlers a) <> (PluginHandlers b) = PluginHandlers $ DMap.unionWithKey go a b
255244
where

0 commit comments

Comments
 (0)