Skip to content

Commit 7bad4db

Browse files
committed
Update nix and CI
1 parent 4613151 commit 7bad4db

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

.github/workflows/test.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ jobs:
170170
name: Test hls-class-plugin
171171
run: cabal test hls-class-plugin --test-options="-j1 --rerun-update" || cabal test hls-class-plugin --test-options="-j1 --rerun" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-class-plugin --test-options="-j1 --rerun"
172172

173-
- if: ${{ needs.pre_job.outputs.should_skip != 'true' && matrix.test && matrix.ghc == '9.0.1' }}
173+
- if: ${{ needs.pre_job.outputs.should_skip != 'true' && matrix.test && matrix.ghc }}
174174
name: Test hls-eval-plugin
175175
run: cabal test hls-eval-plugin --test-options="-j1 --rerun-update" || cabal test hls-eval-plugin --test-options="-j1 --rerun" || LSP_TEST_LOG_COLOR=0 LSP_TEST_LOG_MESSAGES=true LSP_TEST_LOG_STDERR=true cabal test hls-eval-plugin --test-options="-j1 --rerun"
176176

configuration-ghc-901.nix

-2
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ let
99
"hls-fourmolu-plugin"
1010
"hls-splice-plugin"
1111
"hls-ormolu-plugin"
12-
"hls-eval-plugin"
1312
"hls-class-plugin"
1413
"hls-refine-imports-plugin"
1514
];
@@ -106,7 +105,6 @@ let
106105
(pkgs.lib.concatStringsSep " " [
107106
"-f-brittany"
108107
"-f-class"
109-
"-f-eval"
110108
"-f-fourmolu"
111109
"-f-ormolu"
112110
"-f-splice"

plugins/hls-eval-plugin/test/Main.hs

+6-4
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,13 @@ import System.FilePath ((</>))
2020
import Test.Hls
2121

2222
main :: IO ()
23-
main = defaultTestRunner $ if ghcVersion == GHC901 then tests else dummyTestCase
23+
main = defaultTestRunner $ ignore tests
2424

25-
-- | Now we only maintain test cases for GHC 9.0.1
26-
dummyTestCase :: TestTree
27-
dummyTestCase = testCase "Tests are skipped before GHC 9.0.1" $ pure ()
25+
ignore :: TestTree -> TestTree
26+
ignore =
27+
if ghcVersion == GHC901
28+
then id
29+
else ignoreTestBecause "Eval plugin tests are enabled for GHC 9.0.1"
2830

2931
evalPlugin :: PluginDescriptor IdeState
3032
evalPlugin = Eval.descriptor "eval"

0 commit comments

Comments
 (0)