Skip to content

Merge hls-exactprint-utils into ghcide #1200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pepeiborra opened this issue Jan 12, 2021 · 2 comments · Fixed by #1203
Closed

Merge hls-exactprint-utils into ghcide #1200

pepeiborra opened this issue Jan 12, 2021 · 2 comments · Fixed by #1203
Assignees
@pepeiborra
Labels
type: enhancement New feature or request

Comments

@pepeiborra
Copy link
Collaborator

pepeiborra commented Jan 12, 2021 •
edited
Loading

This package contains a single module, Ide.TreeTransform, originally extracted from the tactics plugin, that provides a rather nice API for working with ghc-exactprint.

Ghcide code actions perform a lot of stringy AST rewriting that are both an eye sore and an endless source of bugs.

I want to make it possible to use Ide.TreeTransform in ghcide code actions, so my plan is:

  1. Rename Ide.TreeTransform to Development.IDE.GHC.ExactPrint to make it easier to discover
  2. Move it to the ghcide package to make it usable. This is needed because hls-exactprint-utils depends on ghcide, so ghcide cannot depend on hls-exactprint-utils.
  3. Expose Development.IDE.GHC.ExactPrint from the ghcide package for all the other plugins to use.

@isovector @konn any objections?
@jneira jneira added type: enhancement New feature or request type: refactor labels Jan 12, 2021
@pepeiborra pepeiborra self-assigned this Jan 12, 2021
@isovector
Copy link
Collaborator

No objections

@pepeiborra pepeiborra mentioned this issue Jan 12, 2021
Merged
@konn
Copy link
Collaborator

konn commented Jan 13, 2021

No objections neither!

@mergify mergify bot closed this as completed in #1203 Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pepeiborra pepeiborra

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Extract Development.IDE.GHC.ExactPrint haskell/haskell-language-server
4 participants
@konn @pepeiborra @jneira @isovector