Skip to content

Parse errors in metaprograms have the wrong file offsets #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
isovector opened this issue Jun 22, 2021 · 0 comments · Fixed by #1967
Closed

Parse errors in metaprograms have the wrong file offsets #1964

isovector opened this issue Jun 22, 2021 · 0 comments · Fixed by #1967
Labels
component: wingman type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..

Comments

@isovector
Copy link
Collaborator

The wingman metaprogram parser will give you line/column errors in the event of a bad parse. But these are relative to the start of the metaprogram, not relative to the containing file. Easy to fix; just add the containing source span before printing them out.
@isovector isovector added type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc.. good first issue component: wingman labels Jun 22, 2021
@isovector isovector mentioned this issue Jun 22, 2021
Merged
@mergify mergify bot closed this as completed in #1967 Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: wingman type: bug Something isn't right: doesn't work as intended, documentation is missing/outdated, etc..
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Wingman: Add the correct file offset to metaprogram parse errors isovector/haskell-language-server
1 participant
@isovector