Skip to content

Optimization to semantic tokens extracting logic #4049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
soulomoon opened this issue Feb 4, 2024 · 0 comments · Fixed by #4050
Closed

Optimization to semantic tokens extracting logic #4049

soulomoon opened this issue Feb 4, 2024 · 0 comments · Fixed by #4050
Assignees
@soulomoon
Labels
component: semantic-tokens type: enhancement New feature or request

Comments

@soulomoon
Copy link
Collaborator

soulomoon commented Feb 4, 2024 •
edited
Loading

another thing, though this doesn't have to be addressed in this MR and could be a follow up - now that we are traversing the entire document in order, do we still need to accumulate results into a M.Map Range HsSemanticTokenType? Couldn't we instead directly accumulate a [(Range, HsSemanticTokenType)]?

Originally posted by @wz1000 in #3958 (comment)
@soulomoon soulomoon self-assigned this Feb 4, 2024
@soulomoon soulomoon linked a pull request Feb 4, 2024 that will close this issue
Optimize semantic token extraction logic #4050
Merged
@soulomoon soulomoon added the type: enhancement New feature or request label Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soulomoon soulomoon

Labels
component: semantic-tokens type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Optimize semantic token extraction logic haskell/haskell-language-server
1 participant
@soulomoon