-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added an api module, implements #107 #111
Conversation
@volfpeter I will review this PR after #109 is done if you don't mind. I want to make standard test cases for this project first. |
Sure, it's a good idea. I'll have a look at the current test cases to see how I can write some for this module. |
I've added tests for the
|
@volfpeter Can you run |
For the record, since my previous comment, I've added tests for:
Code coverage is over 90% after these changes, but of course there are plenty of things that could still be tested. |
@chenjr0719 What is the status of this PR? Do you have an estimate when it could get a review? |
@chenjr0719 Hi! Could you please give an estimate when this PR might get reviewed? |
@volfpeter Sorry about no response. I think I can get this done at the end of this Friday. Little busy recent days. |
Thanks. No problem! I just wanted to get some feedback on how things are going. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@volfpeter This PR really impressed me because of the readability and the nice implementation(especially about the partial func part). Very appreciated for your contribution.
But it seems not passed all unit tests which I added in #109. This is not your problem, and I will create an issue about it later. To get this PR merged, could you do me a favor to skip the following test?
https://github.com/huge-success/sanic-openapi/blob/cbf0f5b27fb6b56be048a8ef020b0082ac484543/tests/test_swagger.py#L56-L66
@chenjr0719 I've marked the test as skipped. Thanks for the review and for accepting a whole new module into your project! I'm really happy to have contributed here. One thing I miss a bit is a readme update. Should i do it? I didn't want to start editing the readme without permission or guidance on where you would like to have info about the |
@volfpeter Actually, I would like to create a new document of this project with |
That's great! In this case, I'll leave everthing as it is right now, but please let me know if you need help writing documentation for this module. I'd be happy to help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahopkins I think this PR is ready to merge.
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 96.8% 95.27% -1.54%
==========================================
Files 3 4 +1
Lines 313 423 +110
Branches 68 87 +19
==========================================
+ Hits 303 403 +100
Misses 6 6
- Partials 4 14 +10
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #111 +/- ##
==========================================
- Coverage 96.8% 95.27% -1.54%
==========================================
Files 3 4 +1
Lines 313 423 +110
Branches 68 87 +19
==========================================
+ Hits 303 403 +100
Misses 6 6
- Partials 4 14 +10
Continue to review full report at Codecov.
|
Added an
api
module, that contains:API
: The base class to extend to document routes using a class-based syntax and possibly a single decorator. See its documentation for a proper description and example usage.Response
: Helper class that is required byAPI
to supportdoc.response()
.