Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Message notification sender can be wrong sometimes #389

Closed
marc-farre opened this issue May 8, 2024 · 1 comment · Fixed by #390
Closed

Message notification sender can be wrong sometimes #389

marc-farre opened this issue May 8, 2024 · 1 comment · Fixed by #390
Assignees
@yurabakhtin

Comments

@marc-farre
Copy link
Contributor

MessageNotification::getEntrySender() is used to get the sender of the notification: https://github.com/humhub/mail/blob/master/models/MessageNotification.php#L218C24-L218C38

But it gets the sender from the latest entry: https://github.com/humhub/mail/blob/master/models/MessageNotification.php#L39

If a user adds a participant to the conversation, but is not the creator of the last message entry, the sender is wrong.
@marc-farre marc-farre mentioned this issue May 8, 2024
Open
@yurabakhtin yurabakhtin mentioned this issue May 9, 2024
Merged
@yurabakhtin yurabakhtin linked a pull request May 9, 2024 that will close this issue
Fix notification about participant joining #390
Merged
@yurabakhtin
Copy link
Contributor

@luke- @marc-farre Fixed in PR #390:

test-mail-join

@luke- luke- closed this as completed in #390 May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurabakhtin yurabakhtin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix notification about participant joining humhub/mail
2 participants
@yurabakhtin @marc-farre