Add check for unique chaincode names across channels #528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: IITI-tushar <019saxenatushar@gmail.com>
dzikowski
reviewed
Apr 16, 2025
dzikowski
changed the title
|
Hi @IITI-tushar how is it going? Would you like to complete this PR? |
|
@dzikowski |
|
@dzikowski in the file here's the error output should i commit the test case?? |
|
I would suggest to update the Fablo config file on the fly in test, for instance: const fabloConfigJson = // read and parse fablo config from file
fabloConfigJson.chaincodes[1].name = fabloConfigJson.chaincodes[0].name;
// save the file to temporary location, and then use it in tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : issue#228
This pull request introduces a new validation to ensure that chaincode names are unique across different channels. It includes changes to both the test suite and the core configuration extension logic.
New validation for unique chaincode names:
e2e/fabloCommands.test.ts: Added a test case to check for duplicate chaincode names across different channels, ensuring that the validation throws an error when duplicates are found.src/extend-config/extendChaincodesConfig.ts: Introduced thecheckUniqueChaincodeNamesfunction to validate that all chaincode names are unique within the provided configuration. This function is called within theextendChaincodesConfigfunction.Integration of the new validation:
src/extend-config/extendConfig.ts: Imported thecheckUniqueChaincodeNamesfunction and integrated it into theextendConfigfunction to ensure chaincode names are checked for uniqueness during the configuration extension process.