Fix #340: Connection profile - bugs and missing values #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vijeta Priya <vijetapriya47@gmail.com>
dzikowski
reviewed
Apr 13, 2025
src/setup-docker/index.ts
Outdated
| @@ -101,9 +101,9 @@ export default class SetupDockerGenerator extends Generator { | |||
| }); | |||
| } | |||
|
|
|||
| _createConnectionProfiles(global: Global, orgsTransformed: OrgConfig[]): void { | |||
| _createConnectionProfiles(global: Global, orgsTransformed: OrgConfig[], channels: ChannelConfig[] = [], ordererGroups: OrdererGroup[] = []): void { | |||
There was a problem hiding this comment.
please require explicit parameters (less prone to errors)
Suggested change
| _createConnectionProfiles(global: Global, orgsTransformed: OrgConfig[], channels: ChannelConfig[] = [], ordererGroups: OrdererGroup[] = []): void { | |
| _createConnectionProfiles(global: Global, orgsTransformed: OrgConfig[], channels: ChannelConfig[], ordererGroups: OrdererGroup[]): void { |
Added Explicit Parameters (as suggested by the mentor) Co-authored-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com> Signed-off-by: Vijeta Priya <67923889+VijetaPriya47@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #340 by addressing the following issues with connection profiles:
CA URL in connection profile starts from
http://, even if TLS is enabledMissing
ordererssection (required when service discovery is disabled)Missing
channelssection (required when service discovery is disabled)These changes ensure that Node.js clients can use the connection profiles with service discovery disabled, which is particularly important in dev mode.
Fixes #340