-
Notifications
You must be signed in to change notification settings - Fork 87
Fix #447: Upgrade Blockchain Explorer version to 2.0.0 #522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #447: Upgrade Blockchain Explorer version to 2.0.0 #522
Conversation
Signed-off-by: Vijeta Priya <vijetapriya47@gmail.com>
Signed-off-by: Vijeta Priya <vijetapriya47@gmail.com>
Signed-off-by: Vijeta Priya <vijetapriya47@gmail.com>
@dzikowski @umegbewe |
the |
So, would we have to change test-4 snapshot and test-3 also, according to the new version? |
Just test-4 I think. I don't see any verification of explorer in other test files. |
It's failing test-3 also. Should I review my code again, as to why it's failing test-3 |
You can ignore test-3:
It's because of too many docker pull calls from GH actions. We just need to wait some time and retry. I was just doing a lot of PR merges and updates, and we eventually exceeded the quota. |
it passed test-3. Can we force merge it then? |
Test-4 is failing and action logs suggest explorer is not working. So we cannot merge it. Do you have access to action logs? Does test-4 pass locally? |
log.txt |
When you run The part that suggests explorer is not working correctly is:
I guess there was probably a change in explorer configuration, and the one provided previously needs to be adjusted to make explorer v2 working. A good way to start is to execute the test script locally, and verify explorer container logs. They will probably show what needs to be fixed. |
Yup, I have access to the GitHub Actions log. I ran the e2e-network/docker/test-04-snapshot.sh script locally and compared my output with the CI logs. However, due to some permission issues in my local environment, the output isn't matching the CI logs. I feel I should set it up again and then rerun the script, compare and see where it needs to be fixed. |
This PR fixes issue #447 by upgrading the Blockchain Explorer version from 1.1.8 to 2.0.0.
Changes made:
Fixes #447